Return-Path: <linux-kernel-owner+willy=40w.ods.org-S932114AbWJHXqi@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932114AbWJHXqi (ORCPT <rfc822;willy@w.ods.org>);
	Sun, 8 Oct 2006 19:46:38 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932115AbWJHXqi
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 8 Oct 2006 19:46:38 -0400
Received: from gate.crashing.org ([63.228.1.57]:14520 "EHLO gate.crashing.org")
	by vger.kernel.org with ESMTP id S932114AbWJHXqi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 8 Oct 2006 19:46:38 -0400
Subject: Re: [patch 3/3] mm: fault handler to replace nopage and populate
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <npiggin@suse.de>,
       Linux Memory Management <linux-mm@kvack.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <20061007134407.6aa4dd26.akpm@osdl.org>
References: <20061007105758.14024.70048.sendpatchset@linux.site>
	 <20061007105853.14024.95383.sendpatchset@linux.site>
	 <20061007134407.6aa4dd26.akpm@osdl.org>
Content-Type: text/plain
Date: Mon, 09 Oct 2006 09:46:13 +1000
Message-Id: <1160351174.14601.3.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.8.1 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1533
Lines: 33


> - So is the plan here to migrate all code over to using
>   vm_operations.fault() and to finally remove vm_operations.nopage and
>   .nopfn?  If so, that'd be nice.

Agreed. That would also allow to pass down knowledge of wether we can be
interruptible or not (coming from userland or not). Useful in a few case
when dealing with strange hw mappings.

Now, fault() still returns a struct page and thus doesn't quite fix the
problem I'm exposing in my "User switchable HW mappings & cie" mail I
posted today in which case we need to either duplicate the truncate
logic in no_pfn() or get rid of no_pfn() and set the PTE from the fault
handler . I tend to prefer the later provided that it's strictly limited
for mappings that do not have a struct page though.
 
> - As you know, there is a case for constructing that `struct fault_data'
>   all the way up in do_no_page(): so we can pass data back, asking
>   do_no_page() to rerun the fault if we dropped mmap_sem.
> 
> - No useful opinion on the substance of this patch, sorry.  It's Saturday ;)
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/