Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1682096pxf; Fri, 26 Mar 2021 12:15:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcmyWLeNwze0C8ii38bpvYLRvmKJ+vZanIojTKw032xfRUft3gbOYbE4yz6IF1HcbKe+CR X-Received: by 2002:a17:906:f84b:: with SMTP id ks11mr16827135ejb.296.1616786134431; Fri, 26 Mar 2021 12:15:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616786134; cv=none; d=google.com; s=arc-20160816; b=tqegQVnnVvfdzh6Oigud/fSwBINEhyMtloD4NQaDfNiJRNfNznG1xViBvG5k0qOXPs rqDDhCgRLL1ioWzl3u7kf4RtnfUwP2lXFtxW43GrgyPufTCqvTCQ3OmzgCVPLB+KPSCo DZM+bHppVxb4VYn0rnsfTSK/r9BtjgApY2F7JZWBqZ3iLlgm7r+NNFSoaTehLgAsopTL k/VIb3rEppUotVZmuGWYLWLgDBga3qXBzDh6DqLononcqSe6V1jvHhv47kaTdASNREKN esEeMbzeHXFNDg1ZRVhKJ3K1Q8WKKqOCt3xZ+CO1QCXfCXEJWj0c0cT4UAoqSSUQ4hRp aMkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=i4SGoPyAI0rzN8NEgW4FTfqAiTr+eN0MtA6LVcLc26A=; b=S9lbMjMQg+BZzl3/UeKwtAhu4fMH8OUxpwIQjNElMS32FotMhe63Zqrk1iwXHyumgl pCcsonrXZ9vqI4tBRhQf38UXlGmUYSyAtsj9LNqxD6ABYHoBEZX7Kne4Kt/EcKwG+ypA N+B6vC4zOuJTrdD85CL3sZONwqeQ5v2SYgjw0l1XIVmFwx7KgVWLeOub7TQPuUXwvuoI AOD+//ABk+PMTaet+mnJZachiypiRkl28e2Ov2HXPFwY/Y3U3950VnAZQdZGYUfXHPl1 H2r1hZ7RkrJQ5vDnxvc6cQIlAu3TGRDA1Wet7irdja/pQfcxmJT2tzGAmtDL/k93IFDV UlOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y17si7385139edr.228.2021.03.26.12.15.11; Fri, 26 Mar 2021 12:15:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbhCZTOA (ORCPT + 99 others); Fri, 26 Mar 2021 15:14:00 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:48290 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbhCZTOA (ORCPT ); Fri, 26 Mar 2021 15:14:00 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lPruA-0005L2-79; Fri, 26 Mar 2021 19:13:58 +0000 From: Colin King To: Pawel Laszczak , Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: cdnsp: remove redundant initialization of variable ret Date: Fri, 26 Mar 2021 19:13:57 +0000 Message-Id: <20210326191357.622683-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/usb/cdns3/cdnsp-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c index 7a84e928710e..d87b640e7b49 100644 --- a/drivers/usb/cdns3/cdnsp-mem.c +++ b/drivers/usb/cdns3/cdnsp-mem.c @@ -686,7 +686,7 @@ static void cdnsp_free_priv_device(struct cdnsp_device *pdev) static int cdnsp_alloc_priv_device(struct cdnsp_device *pdev) { - int ret = -ENOMEM; + int ret; ret = cdnsp_init_device_ctx(pdev); if (ret) -- 2.30.2