Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1726077pxf; Fri, 26 Mar 2021 13:26:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWn8nrnIGpqEsGK6fEMjNIUX+v1cf3DRlMYL6WbLE7nRKsKQNilEKFbIUpJ6PWLCKEwicH X-Received: by 2002:a05:6402:1d19:: with SMTP id dg25mr17290566edb.218.1616790407058; Fri, 26 Mar 2021 13:26:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616790407; cv=none; d=google.com; s=arc-20160816; b=XZtx4EqD/GHYgOmx0bqy8oWLuLEoM48Twu5yueLZPD5FgRBSftksLAuOvGd8eTbgcx /odbIcUegjyAOoChg84HTp95YD8zEIwYDidMl6ZaPOpl+nVQsNZ0Qj+wy08+B08aLZMI XOQG82L2HIlZvzxfEUtCSzENMMTb8xwHCby8LaEBnPzn9w1thFMV8+UhhMBZuDXkF3ax uHkn8hY2v9VuNxAEjMgEBAte1hRQ1vp5k6fE3V9K8i1PUjI684jRRSoumvYVXn7SYJAZ A5IGu7sThpKAiipw7jO9nbcGJaupW9bUUpyYW1h3M0acyO3O3kwxPdHIFf9l1uTht4DF H+2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=5z34cqVEPiFQPPc+g2QanD8KGN67FfoACVpCwgARCQw=; b=MxhCqaso88DkMSlNlGJ3WsY4V/H2ctK0WbALPFp0or2Dk4Wp+f+M3ZG8QwMnq3nAOO rk755b+YUcOQzGRhz6z7kDv3F5/lr4WfM/IiUDTxQSHNrPqTyN0etmo5CxgcCLLfOwVw by5WePMMYaKziNE7YiqoFyv2DAR75bm1dWSEpy0u3ZzfpMfR4MXCnM4CJtmlQSuxVqIA Sv0Cr7fTu3DwOQ8qMFhB5UheQhsr9L2xxdd42CmSmRZCox7W0FQek7gkDTVaIUMjiztJ tJ5m+cKnOvDkgdhVItrTIMTS0kXlilSu4FSr6UuiJ5hoA5JAGemQ78zYLdtv9AyUDQKu BgKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=M+5Id7U7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si7647200ejx.732.2021.03.26.13.26.21; Fri, 26 Mar 2021 13:26:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=M+5Id7U7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230159AbhCZUZL (ORCPT + 99 others); Fri, 26 Mar 2021 16:25:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbhCZUYk (ORCPT ); Fri, 26 Mar 2021 16:24:40 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C939EC0613B1 for ; Fri, 26 Mar 2021 13:24:39 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id k25so6683846iob.6 for ; Fri, 26 Mar 2021 13:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=5z34cqVEPiFQPPc+g2QanD8KGN67FfoACVpCwgARCQw=; b=M+5Id7U7uChU5FpwwJKBl6tSDYaRSoYYyECLMoLWvv+As3XPcwyE89uYAvJerEaSD9 5qND+Ysx0yLbrR8QMBP9T8jtrg8a1OaDmB/1MZe4JuXptveEwUAOxtRz0hb29XY51+hc fGOmVonSI4KnRamBGNQcUG4iyALvSnunWh6ZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5z34cqVEPiFQPPc+g2QanD8KGN67FfoACVpCwgARCQw=; b=dcysykv+ESj9bCc7X1fgKMGXCgwKFABcwzqG5jWIFvfDVrwVji4xRY4Vuu8hObfr3W vsqnn6lykFWrK4H/4u934g6yev/KX509mmYmfF9Raq82ebviuQbXCyfT8vWgF3LMZDcC tjNHz+9i7XdU10UiUy4jVC0fZSWTE/r6ziCovdZ2ppkGTpFxLotYhlGSphtVzwXb+Vuu DarzwnjsTwMhZD09rvoVw6mSwgw5OIwCWW8yJ2kec6ysEQKt3IovtCX2AIvuftDPfmAL daK3xuVrCRr4W5ZGJ32Fr7y4dBEonz/4+bUu93hQuT4zIfOeeCO5kh1nnCwo6zdFSFdr 9+oQ== X-Gm-Message-State: AOAM530hsHUKcHSI6Ml2D269sDOsAka+zYZtpDmGQBWD2XXEJoSHIDfJ 48pfphnRMDeRRQPgxs7dvKd1uw== X-Received: by 2002:a6b:c997:: with SMTP id z145mr11378763iof.36.1616790279309; Fri, 26 Mar 2021 13:24:39 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id u5sm4793084iob.8.2021.03.26.13.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 13:24:38 -0700 (PDT) Subject: Re: [PATCH] usbip: vhci_hcd: do proper error handling To: Muhammad Usama Anjum , shuah@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, valentina.manea.m@gmail.com, stern@rowland.harvard.edu, Shuah Khan References: <20210325114638.GA659438@LEGION> From: Shuah Khan Message-ID: Date: Fri, 26 Mar 2021 14:24:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210325114638.GA659438@LEGION> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/25/21 5:46 AM, Muhammad Usama Anjum wrote: > The driver was assuming that all the parameters would be valid. But it > is possible that parameters are sent from userspace. For those cases, > appropriate error checks have been added. > Are you sure this change is necessary for vhci_hcd? Is there a scenario where vhci_hcd will receive these values from userspace? Is there a way to reproduce the problem? thanks, -- Shuah