Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1786137pxf; Fri, 26 Mar 2021 15:01:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza4K0/Lv7VflCsAW0WvOMB/6yNrBJVWhMaIb9qNCcc1zs8bwmSDJrS6gFj/gAzHnsiZxVD X-Received: by 2002:a17:907:75fc:: with SMTP id jz28mr17653867ejc.490.1616796083310; Fri, 26 Mar 2021 15:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616796083; cv=none; d=google.com; s=arc-20160816; b=BqCom5VYAAaS5BZizBx2pZvIi8oh9fqLCg8wF37gLYgucgrCr1YZUbNmQ2f18uqcrz g7+1iPrQaQ8EuE5cDixm1XsNPys3C3BifHwZO9dz839EG3aMhcvg2llC02JzHgqOemrH PpFUhn8cco5otomAcRhJaFq7gklAiTvyVDf1ntLIco7HPfmOAco8XO3eP6+e5VpC2M9p oRvU8GtrJf9gDkDHSvRT2gG1MRnky5d9hAHUv+M09I8yjpTTUeOhHBwQQfWtjUSgfdf5 IX8Co/TqYJwqvfeAACCR4aezy6xhP1eEdGg0qM8FjEcQpFYtSJm0ef/B/aglEiSblkjr miQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=xv0ub4nT+g4o5sHlcAUD1NDqcvuM3jauc2YKDFxgVPU=; b=g+NAKttpah0r1F2BKU6SXI/s2InEQwmmhQroAHLk7bSH+eCmtVOssLYIHZt7eNJxxS 4kcgfbPnj4+Qdvf1W7USVSQQT8CF1NqFyBPqPMZD04MiiAAmtgHd9/qS5fF8AXotP34c ptPbuwrMajTB7GVE1sMFKtnCsvi6VfcXeH69Cd9cu0akEo+mZueBumgovXUlTOglnIkN rBA3qtwOBuD33QK3ECkAkE7mbypmNBl6KGxBtkud4BKcd0dEeuCpbngQY5I45M29dM00 G1RqCO5DWxfgAkeF3MukQ3bCnWAV4NtLi7dlYb1BQ1L+CC+LqKwqr8okVyO56o6MXGK7 3OBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id af9si7786587ejc.470.2021.03.26.15.01.00; Fri, 26 Mar 2021 15:01:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbhCZWAF (ORCPT + 99 others); Fri, 26 Mar 2021 18:00:05 -0400 Received: from mga04.intel.com ([192.55.52.120]:61331 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229969AbhCZV7z (ORCPT ); Fri, 26 Mar 2021 17:59:55 -0400 IronPort-SDR: dm1a2I3fKZ/68L5zE+L1mZVr/Fc4JAYQcUcP1s2lDcLh4UOo6Vt/3HWHa8HvqX+rr6y+YApNkP z/zOykTDN7sw== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="188957048" X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="188957048" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 14:59:54 -0700 IronPort-SDR: Je863sflGveU/77pmbgCmYiQNuc7PUjcdUxpiLAjQaJIPqabbQQaTx5EKNHYVRLp2gvh70oQNi Rtltnk7ZomtQ== X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="416706667" Received: from zcmahone-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.255.231.203]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 14:59:53 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Vijendar Mukunda , Hui Wang Subject: [PATCH 01/17] ASoC: amd: renoir: acp3x-pdm-dma: remove unnecessary assignments Date: Fri, 26 Mar 2021 16:59:11 -0500 Message-Id: <20210326215927.936377-2-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com> References: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cppcheck warning: sound/soc/amd/renoir/acp3x-pdm-dma.c:132:17: style: Variable 'pdm_dma_enable' is assigned a value that is never used. [unreadVariable] pdm_dma_enable = 0x00; ^ sound/soc/amd/renoir/acp3x-pdm-dma.c:156:18: style: Variable 'pdm_dma_enable' is assigned a value that is never used. [unreadVariable] pdm_dma_enable = 0x00; ^ indeed those values are never used because the timeout is reset. Signed-off-by: Pierre-Louis Bossart --- sound/soc/amd/renoir/acp3x-pdm-dma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index 7b14d9a81b97..1acd20439399 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -129,7 +129,6 @@ static int start_pdm_dma(void __iomem *acp_base) enable_pdm_clock(acp_base); rn_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE); rn_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE); - pdm_dma_enable = 0x00; timeout = 0; while (++timeout < ACP_COUNTER) { pdm_dma_enable = rn_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE); @@ -153,7 +152,6 @@ static int stop_pdm_dma(void __iomem *acp_base) if (pdm_dma_enable & 0x01) { pdm_dma_enable = 0x02; rn_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE); - pdm_dma_enable = 0x00; timeout = 0; while (++timeout < ACP_COUNTER) { pdm_dma_enable = rn_readl(acp_base + -- 2.25.1