Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1786157pxf; Fri, 26 Mar 2021 15:01:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFGX0ztE7bZjZHwvbGMK/0u2wNLlwkTx9lHujvpvBP2ABECXZWzHeVfWcJtKv+i9NZlJWX X-Received: by 2002:a17:906:f84b:: with SMTP id ks11mr17338006ejb.296.1616796084898; Fri, 26 Mar 2021 15:01:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616796084; cv=none; d=google.com; s=arc-20160816; b=SGZ20fui9y08tFNkC1AG5La745/uPMnVXfp3AHPLrPtYEJvGBQRNFLQ5bKF7YfIcc/ 3x4s3hnXNGMgXKBFzgVX48LwqZqLRik08FHiXr2iOC6RL+DRsOL4/wdwPxoxFZgDwe1N 7o0vlw4/Q/JVHfGanDM+lyjuaTg5KCwUnqrMhQzl4Ws9j/aVbSjd+DaMP1GWpH2wb0MK nUZ57h/+vbqGcQdiUl5hz+jimhASdJ08Su1FLyZJ/kBrqCLu+EpbE3MYAGuaZ64gtZhr bd//xLulXifuLO4pooG7EkAWLGe0EozBjGNEN8ocqV+dy/U2+FepYx8VQmdNswvAXWBr FYOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=px1Wz8JdO7VHC1+qmL5/3hEzaviC6wRHCFJcdyLbmNA=; b=gJZCxvK9T/scsddBfmNAw/7D4It4akadjcou9FHm4b/wgQ7bqrA7XDuXV7QrPXoBo3 zHCbO7BWDAQRijFBtW4HRI+04KVExcYW7f7aeatOQ5V3GyGnMsg1mBCDHn0UwayYSN19 Kl8Ke2PQq34h9ToHNUYlOsFPJLeIxYChW271aazUOBUFZTSrCv76Y20DaQwUNtA/e1yV LZJ9RorOmPbpglyHNDaWB+/3BnDI2tmBJA3X1hzG793pypmBUmW8YCFiN4uBpVL2d4V0 qgaA8Eq/9l8UpDriLMxUCuZRwGGgLWVY370IEammZRdICjnMPmhY8niU/7S/lweDr5hh wqVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z9si7529902edb.10.2021.03.26.15.01.02; Fri, 26 Mar 2021 15:01:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230296AbhCZWAH (ORCPT + 99 others); Fri, 26 Mar 2021 18:00:07 -0400 Received: from mga04.intel.com ([192.55.52.120]:61331 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230026AbhCZV75 (ORCPT ); Fri, 26 Mar 2021 17:59:57 -0400 IronPort-SDR: QNDFnL9wfxwVi3cHrW5NkSr6mFet9/Wt/i4A5/pw1y+7F0soUAfXwG9xhWRv4L4Nc6iv0EBVgm 1vJAk7+X8plg== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="188957060" X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="188957060" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 14:59:57 -0700 IronPort-SDR: pB408+pzBCoEPBT8sZF5FmcBw4LHKr5AyFUT6dU0vtpWt0fcCZ5siFsPnp18RzUiplSBJx9yZb nrgzhMs4AqfA== X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="416706683" Received: from zcmahone-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.255.231.203]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 14:59:56 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Codrin Ciubotariu , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Microchip (AT91) SoC support) Subject: [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization Date: Fri, 26 Mar 2021 16:59:13 -0500 Message-Id: <20210326215927.936377-4-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com> References: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cppcheck complains: sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization] err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0, ^ sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized int err = -ENXIO; ^ sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0, ^ Signed-off-by: Pierre-Louis Bossart --- sound/soc/atmel/atmel-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/atmel/atmel-i2s.c b/sound/soc/atmel/atmel-i2s.c index 7c6187e41f2b..584656cc7d3c 100644 --- a/sound/soc/atmel/atmel-i2s.c +++ b/sound/soc/atmel/atmel-i2s.c @@ -595,7 +595,7 @@ static int atmel_i2s_probe(struct platform_device *pdev) struct regmap *regmap; void __iomem *base; int irq; - int err = -ENXIO; + int err; unsigned int pcm_flags = 0; unsigned int version; -- 2.25.1