Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1786599pxf; Fri, 26 Mar 2021 15:01:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsJTP2rMRYhgAYZzcEYfKjl8cTmw66xhjXEZ0arJXU5/evkZS5xth49o1cK/2KkKqPI9W9 X-Received: by 2002:a17:906:f2d2:: with SMTP id gz18mr17476645ejb.454.1616796117899; Fri, 26 Mar 2021 15:01:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616796117; cv=none; d=google.com; s=arc-20160816; b=iLJN6Jx0ieVCGgmFBoCFcCS8ZNMaMZiPXm2Tp7tUfiZV4NMzLDKIc9A2w1gUN+ANVD efO6+ocnNn88z5WSxmEAZmxAugKTR8FuSSTE86cHQ9Cf/SqvMWpN5kW3PTb0GvnBYHjI Hb4hj1ajT/fD8ihDPZ62PbWrmRG3xzyENImrZanJ9TnFQft+5ZYr3nowAw0sJGelvoge IL8wwa+F3iBtX3U/A9h9A5ewN47XP5wZZv7JwLFQPB/d1fjEMU+om6j9PAfKHC8fXMNr B1LoegNYkBMsgCI+d0Eo0HiSHmocEfGDZeoRzGk8i0ifOaWXenQ6Gv84uwdXsgFwkLTx 3rYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=8a6PJ046/KQ0kJek+68NBC8L7WADXaC1JEXBZO4ioPM=; b=d7Y1fmspA6F38sivjzELeI5GMup6BbHQ9ZOWD+dNYPEG1eXIDwTZYdxGD1tio2YZdg FMIz5KU3o3ZinI1gugL8FPeFeUWeU6AHajHef+DlbtdIGog0WlOQon6E0hexiSRKgIHY w7/dBQ6UnI70nefklVrkdt+7KfDihkAVyEsG84wKHxJABOwV1+6NJvJ4dfgTIR1t/qsa L0Ef8t45ffjXvSxMnfDUab2nGApb4AxLi+oAd4avFUBgcMYmOl7BnKYFMCnIRFvzbmFw 6rfwjYb1+qZk6lVLNE/9wtdsuIRZIG1+JeGqgvWr9OcdLDGVKxbTAoymRJ9cp2pVlV4A eYTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b16si7828204eds.502.2021.03.26.15.01.35; Fri, 26 Mar 2021 15:01:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231154AbhCZWAr (ORCPT + 99 others); Fri, 26 Mar 2021 18:00:47 -0400 Received: from mga04.intel.com ([192.55.52.120]:61331 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230378AbhCZWAO (ORCPT ); Fri, 26 Mar 2021 18:00:14 -0400 IronPort-SDR: Ald12DQII2uKRBl74/ytIMGeVMJQHuhFGnwIQSG+8xH24zr0drpQt7TY2qbDeGGdH5aC7ZC1i3 wm5k4WGMGtIw== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="188957134" X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="188957134" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 15:00:13 -0700 IronPort-SDR: VJAH5WVjhPt4JQZSA/x4BysEr0LbukiDsMA6a0UaInhYJs94LgfJtIFHyAx7J0a0m8XKAWS0Af XGBN3/OuZ5CQ== X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="416706881" Received: from zcmahone-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.255.231.203]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 15:00:12 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE SUPPORT) Subject: [PATCH 12/17] ASoC: tegra: tegra20_das: clarify expression Date: Fri, 26 Mar 2021 16:59:22 -0500 Message-Id: <20210326215927.936377-13-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com> References: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cppcheck warning: sound/soc/tegra/tegra20_das.c:64:60: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] reg = otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P | ^ sound/soc/tegra/tegra20_das.c:65:61: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] !!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P | ^ sound/soc/tegra/tegra20_das.c:66:61: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] !!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P | ^ Signed-off-by: Pierre-Louis Bossart --- sound/soc/tegra/tegra20_das.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/tegra/tegra20_das.c b/sound/soc/tegra/tegra20_das.c index 79dba878d854..69c651274c12 100644 --- a/sound/soc/tegra/tegra20_das.c +++ b/sound/soc/tegra/tegra20_das.c @@ -61,10 +61,10 @@ int tegra20_das_connect_dap_to_dap(int dap, int otherdap, int master, addr = TEGRA20_DAS_DAP_CTRL_SEL + (dap * TEGRA20_DAS_DAP_CTRL_SEL_STRIDE); - reg = otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P | - !!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P | - !!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P | - !!master << TEGRA20_DAS_DAP_CTRL_SEL_DAP_MS_SEL_P; + reg = (otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P) | + (!!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P) | + (!!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P) | + (!!master << TEGRA20_DAS_DAP_CTRL_SEL_DAP_MS_SEL_P); tegra20_das_write(addr, reg); -- 2.25.1