Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1787805pxf; Fri, 26 Mar 2021 15:03:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3QY6rc7+iOOsJU5Km6vKvHgREb4pz2EubRp0gTmf1KQWN74FpMoMPiusLGe0Ka0CZqlXS X-Received: by 2002:aa7:d0c2:: with SMTP id u2mr17327371edo.158.1616796207708; Fri, 26 Mar 2021 15:03:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616796207; cv=none; d=google.com; s=arc-20160816; b=EKlu1BXiuROMSRIQkd2Es4/hmSy/NQMZUDR8FNXsJux3YRcUDc8k91XLRtkj2v/oN4 dQ51SUnzaDrwa8AT0vkRZ5e2onveo/hB3K9/6O8xgW6YIxnDVFbPW7v0Ku45kCFhAwJm IuIyFnpJbiPp7+z3pn4aNiGQ4r2HKVp7cYkIhQ/D+uNF/qli3IU89ux/XRidQBFRgiGe f298iBidwAZVTYoT4feKua0jSpi1IL2lpKydQHys1NopuBQlhH4iFhKm9yQ8z+j80joA 2EKDW7lRe0LdfET+mTJ3+PlfGsYuZf0scqjDATOcpB8SNP3uL5D2ZaO19+YiBpp3kqzF WZPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=lYUPlDPjh9ixU49MOBBbssEmQz8k0LNZvpIjTeBLEaI=; b=QZm3uUjn4+4IKfU7FEO1rPvENepxGKjs9AnYkQr1fOyqNDer30S6ec82a3j1Rt4/NT yagxCQjRElwYsyCLsQtayQgjnDgJR+wV7LoDd/ZAYsbCCGUGdvzfb3Ss8LyiG+Qep73T BfXYJI6/2eoGSfdjeV7wTupprhZaCZC8l9pavhXSK9Omk2pF+ZDoe6trWMKjhGlok7qv /ZJpNutC0aaczocpuMgO7jR4i1NgR4KCTTTFP5Z/5KPZIllxuNS1ydPDBvbuADoAUDy7 V1meIWjxTib2ByW9NTUmEBcr+XRIlDzrOYjHzeP87CH6XYP8DJqg7OgJPHNg6Ic7Wu1n oaWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k1si8084334ejp.353.2021.03.26.15.03.05; Fri, 26 Mar 2021 15:03:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbhCZWAI (ORCPT + 99 others); Fri, 26 Mar 2021 18:00:08 -0400 Received: from mga04.intel.com ([192.55.52.120]:61331 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230027AbhCZWAA (ORCPT ); Fri, 26 Mar 2021 18:00:00 -0400 IronPort-SDR: gFf/czvSbQtD6QfpaYPn5OKgnDGaywzu9MF1UaGF/4QfBBbwin4386kNvrOAosqQO5lre5nWLn 7KVgbE55oOng== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="188957067" X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="188957067" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 14:59:59 -0700 IronPort-SDR: LJdCYQN16RvUYsE4gJWf4ZNI9EGbp1jH90sWQAEot3oGg+y9m+5BtO26kjAZpyORhn661R/J7i OQeje9hHsxsQ== X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="416706691" Received: from zcmahone-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.255.231.203]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 14:59:58 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM IPROC ARM ARCHITECTURE), Kuninori Morimoto , Ranjani Sridharan , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE) Subject: [PATCH 04/17] ASoC: bcm: cygnus_ssp: remove useless initialization Date: Fri, 26 Mar 2021 16:59:14 -0500 Message-Id: <20210326215927.936377-5-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com> References: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cppcheck warning: sound/soc/bcm/cygnus-ssp.c:1364:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization] err = devm_snd_soc_register_component(dev, &cygnus_ssp_component, ^ sound/soc/bcm/cygnus-ssp.c:1313:10: note: err is initialized int err = -EINVAL; ^ sound/soc/bcm/cygnus-ssp.c:1364:6: note: err is overwritten err = devm_snd_soc_register_component(dev, &cygnus_ssp_component, ^ Signed-off-by: Pierre-Louis Bossart --- sound/soc/bcm/cygnus-ssp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c index 6e634b448293..fea296b41a43 100644 --- a/sound/soc/bcm/cygnus-ssp.c +++ b/sound/soc/bcm/cygnus-ssp.c @@ -1310,7 +1310,7 @@ static int cygnus_ssp_probe(struct platform_device *pdev) struct device_node *child_node; struct resource *res; struct cygnus_audio *cygaud; - int err = -EINVAL; + int err; int node_count; int active_port_count; -- 2.25.1