Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4/4] crypto: hisilicon/zip - support new 'sqe' type in
 Kunpeng930
To:     Herbert Xu <herbert@gondor.apana.org.au>
References: <1616139187-63425-1-git-send-email-shenyang39@huawei.com>
 <1616139187-63425-5-git-send-email-shenyang39@huawei.com>
 <20210326091457.GA1153@gondor.apana.org.au>
CC:     <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <wangzhou1@hisilicon.com>
From:   "shenyang (M)" <shenyang39@huawei.com>
Message-ID: <833da1eb-0277-8466-23dc-15533eafbd8f@huawei.com>
Date:   Sat, 27 Mar 2021 10:59:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20210326091457.GA1153@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2021/3/26 17:14, Herbert Xu wrote:
> On Fri, Mar 19, 2021 at 03:33:07PM +0800, Yang Shen wrote:
>>
>> +const struct hisi_zip_sqe_ops hisi_zip_ops_v2 = {
>> +	.sqe_type		= 0x3,
>> +	.fill_addr		= hisi_zip_fill_addr,
>> +	.fill_buf_size		= hisi_zip_fill_buf_size,
>> +	.fill_buf_type		= hisi_zip_fill_buf_type,
>> +	.fill_req_type		= hisi_zip_fill_req_type,
>> +	.fill_tag		= hisi_zip_fill_tag_v2,
>> +	.fill_sqe_type		= hisi_zip_fill_sqe_type,
>> +	.get_tag		= hisi_zip_get_tag_v2,
>> +	.get_status		= hisi_zip_get_status,
>> +	.get_dstlen		= hisi_zip_get_dstlen,
>> +};
>> +
>
> This triggers a new warning:
>
>   CHECK   ../drivers/crypto/hisilicon/zip/zip_crypto.c
>   ../drivers/crypto/hisilicon/zip/zip_crypto.c:527:31: warning: symbol 'hisi_zip_ops_v1' was not declared. Should it be static?
>   ../drivers/crypto/hisilicon/zip/zip_crypto.c:540:31: warning: symbol 'hisi_zip_ops_v2' was not declared. Should it be static?
>
> Please fix.  Thanks.
>

Sorry， I'll fix this in next version.

Thanks.