Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1981873pxf; Fri, 26 Mar 2021 22:45:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbn1KQVPJC8r3qV9/J5StrdM+eqnvtTozpThKHuYE4uzVaG+jAblkPSivUcZvwUtzioMI+ X-Received: by 2002:a05:6402:4415:: with SMTP id y21mr18401224eda.70.1616823913016; Fri, 26 Mar 2021 22:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616823913; cv=none; d=google.com; s=arc-20160816; b=tQfrjJkJanQNcRvxZnA+h04k7lQTzRgndSP3oY12pq++6fzxr1SnKRazl5768bI25H 6agOnix67ZX8FInkuGDQJ0wpihNWvskfp5hXfiMlKh8wksjCD0fzjLoRm/E4IXNjzMie BtPP+41R4GQ8gTSABsgvByaPU0WXVwGK57keuITpunaxYb5dxIhpEJz20vUBYkaYT2jj vZdXEpzKBDsMZUKfGWWsSVW8154EG+gadZwn9sZNMIrHCu/gbQNXoVt5Mvw6JrHrwKJ8 lavPg9SDMVSegO3pExWexOLq7crbDwcdUk07Eh2rcmwZKvedINSL00nuqMYf5Rx+Hg6N Fyxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=brobHUhODMFX1VVWlNTrZaewg0aAOtoDHEYeD0xaIS0=; b=NsfSNEVMPXoDJyWokl5Cp9f296DTsLBCB9T8pwDoxrlN5zSnq/HrFDdNLA2OrnbXkS bVMojYMx/4BTIbt2PAN80KjBeF4rkfoc1eDPpQQTnl8fbSmnfm/cb6222lZ8MX3tqUEh USH5D7FoshEHvtbr0MrYCjCJhbzXyjjW41DrnQ/a0a/O68k9rNKt+OZa1dphb/Z/88C1 4sgQz7XFxYERo5NSp8zVdtj/ZV4Xbu2wXAe4X8EXz9AVea6+xI3043pnJY8EhHXBrsA0 LGTgGtb71PCda7V6EIP1+OzpL+XKlZ8zPDFXJbJweMIRJ6c988Gg8SEf9lEDOveJmKcj qRrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DzV1szVc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cn4si8336105edb.52.2021.03.26.22.44.51; Fri, 26 Mar 2021 22:45:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DzV1szVc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbhC0Fme (ORCPT + 99 others); Sat, 27 Mar 2021 01:42:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:47456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhC0Fmd (ORCPT ); Sat, 27 Mar 2021 01:42:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 282B161A1E; Sat, 27 Mar 2021 05:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616823753; bh=loaJcrol/PTRVMRrsww1gLT50nDJ8omknyueW0Pevuk=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=DzV1szVcasJX5KBkovy9pnJvfQVw3rx/z5xQOT2C8Dei+lW9UITUAVapAFTENymXn Mf7DW9BnhTrjeLrXw1aMATkiBOwblGGD+kp2LDK6Qo/aAfa7Z7MsMD6Pzy9YbtjBCW aEr/VwSg1EeZaiWQ0UOxv7W7kmEqcsyThfIymufeMiNLI2+QagnvfIJRMNz2oCmEmU U2S659OMtVBW6nAG31W3cnDIERaR3MjUeeXkXpRnqDjTM4sX5SivWoyC6kpCk99oIO R6b+ETVQxEk0IgXH4iL96HMXb3/5Hf5lDFDTENIAtca8qV/S0gkBGiyTULpHSYf/Ol UiE4FkKdUhEcA== Received: by mail-oi1-f170.google.com with SMTP id n140so7888117oig.9; Fri, 26 Mar 2021 22:42:33 -0700 (PDT) X-Gm-Message-State: AOAM530c+ujf9rCio6u2vtJNwYAMRAvl6k+MkSZoEaef/9cBA7SaJ1Mq 8q2RSCKLpwNE6EmV/K3b+vWaoVuYaonmLme6+q0= X-Received: by 2002:aca:f4ce:: with SMTP id s197mr12125327oih.94.1616823752543; Fri, 26 Mar 2021 22:42:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:5ed4:0:0:0:0:0 with HTTP; Fri, 26 Mar 2021 22:42:31 -0700 (PDT) In-Reply-To: <20210325173538.485917-1-colin.king@canonical.com> References: <20210325173538.485917-1-colin.king@canonical.com> From: Namjae Jeon Date: Sat, 27 Mar 2021 14:42:31 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Linux-cifsd-devel] [PATCH][next] cifsd: remove redundant assignment to variable err To: Colin King Cc: Namjae Jeon , Sergey Senozhatsky , Steve French , Hyunchul Lee , linux-cifs@vger.kernel.org, linux-cifsd-devel@lists.sourceforge.net, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2021-03-26 2:35 GMT+09:00, Colin King : > From: Colin Ian King > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King I will apply. Thanks for your patch!