Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 05/15] remove useless return statement for void function
To:     <rjw@rjwysocki.net>, <lenb@kernel.org>, <rui.zhang@intel.com>,
        <bhelgaas@google.com>
References: <1616827256-51840-1-git-send-email-tanxiaofei@huawei.com>
 <1616827256-51840-6-git-send-email-tanxiaofei@huawei.com>
CC:     <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-pci@vger.kernel.org>, <linuxarm@openeuler.org>
From:   Xiaofei Tan <tanxiaofei@huawei.com>
Message-ID: <dce63f98-9825-3204-fb0e-0e4d958bf581@huawei.com>
Date:   Sat, 27 Mar 2021 14:49:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <1616827256-51840-6-git-send-email-tanxiaofei@huawei.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Oh, sorry, the title doesn't contain subsystem and module name. I'll 
send v2 later. Please ignore this one. thanks.

On 2021/3/27 14:40, Xiaofei Tan wrote:
> Remove useless return statement for void function, reported by
> checkpatch.pl.
>
> WARNING: void function return statements are not generally useful
> FILE: drivers/acpi/acpi_ipmi.c:482:
> +       return;
> +}
>
> Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
> ---
>  drivers/acpi/acpi_ipmi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
> index 9d6c0fc..bbd00d9 100644
> --- a/drivers/acpi/acpi_ipmi.c
> +++ b/drivers/acpi/acpi_ipmi.c
> @@ -478,7 +478,6 @@ static void ipmi_register_bmc(int iface, struct device *dev)
>  	ipmi_dev_release(ipmi_device);
>  err_ref:
>  	put_device(smi_data.dev);
> -	return;
>  }
>
>  static void ipmi_bmc_gone(int iface)
>