Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2050984pxf; Sat, 27 Mar 2021 01:13:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyA/b+uujf9Jb7wj/6R7NlXXK2SN6rYUlMk1Uv3ddMaQSWxHMrfUJ98pa5HdVx+qElxEcmQ X-Received: by 2002:aa7:d4d6:: with SMTP id t22mr19572957edr.376.1616832801645; Sat, 27 Mar 2021 01:13:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616832801; cv=none; d=google.com; s=arc-20160816; b=dbiDKW8FSAQYJ7nk6Oof3vy+mH0lYILw0qtblNbnpHPy8/Kpe8pB0kcuGUMJ/DCeN5 ap3HmRwfqoGlYKShlDfouPLBAKoNyhY4oFLyb/2b7S3c76V9YOpX0FuFRoz/P5xhpGvY Dx8eNxJyekH9mdTZknMkkMhbHQXTXQ20zXNQgvvTWnc/Bk7Wo3So5wLrTgSQORUXSzU2 mmUmShZSPprcVqwkCXmO0n2GCCZlx+5Vf/a0kFh5Xv82PlWnAPCZ9CSVLSlke+b2twGQ Crje9afpFv6t6KLgyi3pdvWTaPFPWWiQIKRCq7HU0x4iqB/YNCS/2qa2kRGXecCy5ZoU gwFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=xjD13NMxwaVJuygjwMKqd9zu6Bu3vN9pgkP/NlmPxvU=; b=LoX3g4kHQdM/8F7Hdyt69/R1ao6nrOav47n0QCcqrhscNSCp0qVLQmntoTvn8lIFML x/+txJ4k54k+euM866OMRHy0Q9A+4zCXWNFi0RSn0788mV5PejsLqWGZMtAWMpuMWzIc hUj+rZiVr8X0aA9fFUD+kcNVxc0sujpbLSLIulisxUTwfU0FOREPHqWCz1E1P1X1A+6I i5brOCXdTy/GqsshEXJtjq4ntA/Qc2XSB2dKSTQ6QgiwSS3H4DPpfBTv7oNI3I+F93Mo hEWI2tKNOFtuFEzYF9RPbxG7zFGUEBRkGUVPZQobzMR7ft0NV/DVvVvjCtiRVB4HQka9 E9uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o9si9468124ejr.588.2021.03.27.01.12.59; Sat, 27 Mar 2021 01:13:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231635AbhC0HuD (ORCPT + 99 others); Sat, 27 Mar 2021 03:50:03 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:15342 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230471AbhC0HtT (ORCPT ); Sat, 27 Mar 2021 03:49:19 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F6rXK41NXz93yg; Sat, 27 Mar 2021 15:47:13 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Sat, 27 Mar 2021 15:49:05 +0800 From: Xiaofei Tan To: , , , CC: Xiaofei Tan , , , , Subject: [PATCH v2 11/15] ACPI: CPPC: fix some coding style issues Date: Sat, 27 Mar 2021 15:46:29 +0800 Message-ID: <1616831193-17920-12-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1616831193-17920-1-git-send-email-tanxiaofei@huawei.com> References: <1616831193-17920-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Missing a blank line after declarations WARNING: unnecessary whitespace before a quoted newline ERROR: spaces required around that '>=' ERROR: switch and case should be at the same indent Signed-off-by: Xiaofei Tan --- drivers/acpi/cppc_acpi.c | 71 ++++++++++++++++++++++++------------------------ 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index ae53740..3dbaf47 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -326,6 +326,7 @@ static int send_pcc_cmd(int pcc_ss_id, u16 cmd) if (unlikely(ret)) { for_each_possible_cpu(i) { struct cpc_desc *desc = per_cpu(cpc_desc_ptr, i); + if (!desc) continue; @@ -777,7 +778,7 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) cpc_ptr->cpc_regs[i-2].type = ACPI_TYPE_BUFFER; memcpy(&cpc_ptr->cpc_regs[i-2].cpc_entry.reg, gas_t, sizeof(*gas_t)); } else { - pr_debug("Err in entry:%d in CPC table of CPU:%d \n", i, pr->id); + pr_debug("Err in entry:%d in CPC table of CPU:%d\n", i, pr->id); goto out_free; } } @@ -867,7 +868,7 @@ void acpi_cppc_processor_exit(struct acpi_processor *pr) void __iomem *addr; int pcc_ss_id = per_cpu(cpu_pcc_subspace_idx, pr->id); - if (pcc_ss_id >=0 && pcc_data[pcc_ss_id]) { + if (pcc_ss_id >= 0 && pcc_data[pcc_ss_id]) { if (pcc_data[pcc_ss_id]->pcc_channel_acquired) { pcc_data[pcc_ss_id]->refcount--; if (!pcc_data[pcc_ss_id]->refcount) { @@ -954,22 +955,22 @@ static int cpc_read(int cpu, struct cpc_register_resource *reg_res, u64 *val) val, reg->bit_width); switch (reg->bit_width) { - case 8: - *val = readb_relaxed(vaddr); - break; - case 16: - *val = readw_relaxed(vaddr); - break; - case 32: - *val = readl_relaxed(vaddr); - break; - case 64: - *val = readq_relaxed(vaddr); - break; - default: - pr_debug("Error: Cannot read %u bit width from PCC for ss: %d\n", - reg->bit_width, pcc_ss_id); - ret_val = -EFAULT; + case 8: + *val = readb_relaxed(vaddr); + break; + case 16: + *val = readw_relaxed(vaddr); + break; + case 32: + *val = readl_relaxed(vaddr); + break; + case 64: + *val = readq_relaxed(vaddr); + break; + default: + pr_debug("Error: Cannot read %u bit width from PCC for ss: %d\n", + reg->bit_width, pcc_ss_id); + ret_val = -EFAULT; } return ret_val; @@ -993,23 +994,23 @@ static int cpc_write(int cpu, struct cpc_register_resource *reg_res, u64 val) val, reg->bit_width); switch (reg->bit_width) { - case 8: - writeb_relaxed(val, vaddr); - break; - case 16: - writew_relaxed(val, vaddr); - break; - case 32: - writel_relaxed(val, vaddr); - break; - case 64: - writeq_relaxed(val, vaddr); - break; - default: - pr_debug("Error: Cannot write %u bit width to PCC for ss: %d\n", - reg->bit_width, pcc_ss_id); - ret_val = -EFAULT; - break; + case 8: + writeb_relaxed(val, vaddr); + break; + case 16: + writew_relaxed(val, vaddr); + break; + case 32: + writel_relaxed(val, vaddr); + break; + case 64: + writeq_relaxed(val, vaddr); + break; + default: + pr_debug("Error: Cannot write %u bit width to PCC for ss: %d\n", + reg->bit_width, pcc_ss_id); + ret_val = -EFAULT; + break; } return ret_val; -- 2.8.1