Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2059553pxf; Sat, 27 Mar 2021 01:27:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+MzJILpPIsPzjzL7zdzmIfMFhvnXhr7/pxxcEma9PIexboPWzrQIN6d+8w1XqWUTDMS0l X-Received: by 2002:a17:906:14d4:: with SMTP id y20mr19335895ejc.190.1616833676074; Sat, 27 Mar 2021 01:27:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616833676; cv=none; d=google.com; s=arc-20160816; b=NZsLvTDemWvv5it0rFo2UjkzcWo1SLEeeyKVaiN4d3lgHXKYPAuvb1/k7Zic0MGrhA v9IPlQLmpnU+8s62r9DZPFrlfcmo+Vam0O7kRv9JpbQIv5D31UG9gn++RfHCrpiSQfdo Xepopa9B6rbec6/jMp5o7gNR1i5a3dTHDMR15HptTZ2uUch5DXlbJGsyXXIWJyj8CGRg JT4i7W5WkCnq9uJdhNdbovAYt0YIotJ2Dj4RZl8potjuL8pgRZMR/xljwDZMHCg2AOci lnKjc9hFysaQyMrhzc4f2Uod9NKjG51QBGrvxfzKad2NcyqebviqO0floAcgRQENyAZC y8BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HXMWNDQbMJC2pNLyvsUAp1+hk7Pgd2JKUMYOKTb8v3Q=; b=NUK6j9jRX2FhcRCpkQkbb1pD3s7v7WggB7Nyilw4J6yINlRygn41iwOG2OI6vC4A47 /g1XcX4J5qrUSehUliWn83w+JfUb9s65vk2LqQ8s2eifq33LqrYZCHrYqtF2UjZnpFNI WKEOiUz3DSru9+8ihszIMmWr66B4K7x7SPl9aU3ICB/+TQwq6ixQT6BGBgozjelE+uLN paZeVw7NelFx0LXu8I1wpfmH36bCcXBcjH6xLOlIip7gJ8mshrSKm3YuCfBsrRsC4aVp 9zi2gpMSjSJT3vCovzaspgRQcslm7WeMcOnogwpwrur/4U40FMpngjqQBcGPa8DFWXLE /LIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SvrZTJXv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o9si9468124ejr.588.2021.03.27.01.27.33; Sat, 27 Mar 2021 01:27:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SvrZTJXv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230322AbhC0I0h (ORCPT + 99 others); Sat, 27 Mar 2021 04:26:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbhC0I02 (ORCPT ); Sat, 27 Mar 2021 04:26:28 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB458C0613B1; Sat, 27 Mar 2021 01:26:23 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id i26so11140577lfl.1; Sat, 27 Mar 2021 01:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HXMWNDQbMJC2pNLyvsUAp1+hk7Pgd2JKUMYOKTb8v3Q=; b=SvrZTJXvdEocuHaG+xo/n05ji5C+L+4JwDc/e6O/Fogmbj5mmtIObBtdz8lKeGBjb6 n0V3B8ah2oW/a8ZfX/tKbZjMq+KXsrh3fidAFwkJew6al256wsyazbXvV2fwXVz1BKLe w/g4lxYxupNR/Uf9/5dvnhTs7yk1ydKoI5k+/0vXJGEChJ4LbRdubd/vxGcIqh/G9mY9 A48OfCBLcteraN1ax5YerK6JaeTz84TVN2d22zzuvrva/9AiUZOxmzAyNlP2/18Z84kS qoHJkQ3oDczTstEOnxxJTyXzGvl4A6k3wJWsEgoAtH+htyBkkUJrrwypAprOwnqFxALd zIbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HXMWNDQbMJC2pNLyvsUAp1+hk7Pgd2JKUMYOKTb8v3Q=; b=iLMvfcJdoqjYsAkFvxoWX0UEL1k+0ZU1Smsmt40K8yTszQg6cwP5sxr4sgZY7f5rKI wMH77Uym8ioG9OBfKUzxw2F8Y50fTk9O6kQE0nDFsbAGcbGEVYtWItHS7Xn8uiWRyKte RgmHba7860vb+6zEwN6/TyUcSFvwnEJflUQVdkR8EBTq3hksaDl7Rp8rHpIVEaWu26gk IiGQsnuWpB66t/8BZ/KodDz5j9RY2+VAX6Cfg2U4W1toMXN8+rW4EbdrhcvrBq8Nm9Q5 xOZSGSFo0Mmc/UNnLHjobiFHWVVgCPFMVAJZ9MyurzIS2zzIeIqcnX7L/ShcWsuQEXTR VLnQ== X-Gm-Message-State: AOAM532pc534UMChN7PJGGKbgEmvoI2VQem6R3SunDOaAMXRTRS9rray Fq/gxr9jdpNNWpF03X9ACsE329ZPKgmB4WQC X-Received: by 2002:a05:6512:3390:: with SMTP id h16mr10875452lfg.479.1616833582353; Sat, 27 Mar 2021 01:26:22 -0700 (PDT) Received: from localhost.localdomain ([94.103.227.42]) by smtp.gmail.com with ESMTPSA id 21sm1126966lfh.231.2021.03.27.01.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Mar 2021 01:26:21 -0700 (PDT) From: Pavel Skripkin To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Skripkin , syzbot+889397c820fa56adf25d@syzkaller.appspotmail.com Subject: [PATCH] media: usb: fix memory leak in em28xx_dvb_init Date: Sat, 27 Mar 2021 11:26:13 +0300 Message-Id: <20210327082613.4702-1-paskripkin@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org syzbot reported memory leak in em28xx_dvb_init()[1] The problem was in wrong error handling after em28xx_alloc_urbs()[2] call. In case of error allocated urbs must be freed backtrace: [] kmalloc_array.constprop.0+0x41/0x60 include/linux/slab.h:594 [] kcalloc include/linux/slab.h:623 [inline] [] em28xx_alloc_urbs+0x102/0x550 drivers/media/usb/em28xx/em28xx-core.c:930 [2] [] em28xx_dvb_init drivers/media/usb/em28xx/em28xx-dvb.c:1517 [inline] [1] [] em28xx_dvb_init.cold+0xa3/0x2bb1 drivers/media/usb/em28xx/em28xx-dvb.c:1483 [] em28xx_init_extension+0x9b/0xe0 drivers/media/usb/em28xx/em28xx-core.c:1126 [] request_module_async+0x33/0x40 drivers/media/usb/em28xx/em28xx-cards.c:3406 [] process_one_work+0x2c9/0x600 kernel/workqueue.c:2275 [] process_scheduled_works kernel/workqueue.c:2337 [inline] [] worker_thread+0x2fb/0x5d0 kernel/workqueue.c:2426 [] kthread+0x178/0x1b0 kernel/kthread.c:292 [] ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 Reported-by: syzbot+889397c820fa56adf25d@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin --- drivers/media/usb/em28xx/em28xx-dvb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c index 526424279637..471bd74667e3 100644 --- a/drivers/media/usb/em28xx/em28xx-dvb.c +++ b/drivers/media/usb/em28xx/em28xx-dvb.c @@ -2010,6 +2010,7 @@ static int em28xx_dvb_init(struct em28xx *dev) return result; out_free: + em28xx_uninit_usb_xfer(dev, EM28XX_DIGITAL_MODE); kfree(dvb); dev->dvb = NULL; goto ret; -- 2.30.2