Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2063969pxf; Sat, 27 Mar 2021 01:35:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfrAHZSOp/r7dBiNMlYJYKY6+wnlOChPPMhhBL2xM8Nv+f5te5bSzYZWnN7oo5eM++B25B X-Received: by 2002:a17:906:86c1:: with SMTP id j1mr19871424ejy.373.1616834137277; Sat, 27 Mar 2021 01:35:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616834137; cv=none; d=google.com; s=arc-20160816; b=aDwt1wPN1b1U3LdiyT0X4RcD/IVDRDcEZlDLer2gJ4zBH0ZFTxYlR/qhuC5L/D/wN7 OEiQCsau6+NfIx5AJTbT+kS9TX4Hx6bMcnI7NZ35aGoNMd3ZIq8y5CDR9p2RGpN/lmBM /i6Jr+3DQxv0KmKkR5WW3FYqzjdt/VU5IyoVxuNU0804ANyA2ZpcAlyMMSPmxsMzUtC2 8DZVJXc+abi+zYSGwsJNI7e0JOFzrrUMxKJtCI/QRZPi3fpUzjTvyHoH1dOYeiQZtwSw RhCuCO68HF/SSC88ShNWhGQzzrDM9PstQ/jH0KFp4nT2L/YwmhWoHW7bP3y4GyU3tv5e McWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=5wSQrK2fEJFkXtzZGhD5Wzkijo5S3vTxX/aVRnVG4LI=; b=zESyCEAUJIHZ4i2Fv3qsQa9hw4WiXOTpl/OXsHuru8az3Am5lCiEgKGHJr2KcIaDd6 +BQTUbv1zPGmXebS8WWWQB+gGI3r4bCgY1w9mtod8FP/gj7+7VogisItIdQ6j6DF/IUD oqC7ggiV3Vx8yi+rJvz1gcwGu85LRlIHoit6yXcH7bkk4vAWNE/coHlHulpv1sFYZVR+ qhfwXRDTuQrsoh7j0WVoH9JMTf/7dViw3au7S7RY/8HO7KVgBnJPuRkkuCr0nNMaTHAJ sxMnOhwidiuBL2DqCRiM3EBuPnii1KCxkEap8f3MBJZMVsJPEak3aDMKRx8lptpmLRI8 vPpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca25si8749009edb.204.2021.03.27.01.35.15; Sat, 27 Mar 2021 01:35:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbhC0Idz (ORCPT + 99 others); Sat, 27 Mar 2021 04:33:55 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:15352 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231211AbhC0Idp (ORCPT ); Sat, 27 Mar 2021 04:33:45 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F6sWd6fJHz8y9f; Sat, 27 Mar 2021 16:31:41 +0800 (CST) Received: from huawei.com (10.175.103.91) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Sat, 27 Mar 2021 16:33:40 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next] fs: dlm: fix missing unlock on error in accept_from_sock() Date: Sat, 27 Mar 2021 16:37:04 +0800 Message-ID: <20210327083704.1092954-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the missing unlock before return from accept_from_sock() in the error handling case. Fixes: 6cde210a9758 ("fs: dlm: add helper for init connection") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- fs/dlm/lowcomms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 73cc1809050a..166e36fcf3e4 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -931,6 +931,7 @@ static int accept_from_sock(struct listen_connection *con) result = dlm_con_init(othercon, nodeid); if (result < 0) { kfree(othercon); + mutex_unlock(&newcon->sock_mutex); goto accept_err; } -- 2.25.1