Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932323AbWJIHkt (ORCPT ); Mon, 9 Oct 2006 03:40:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932325AbWJIHks (ORCPT ); Mon, 9 Oct 2006 03:40:48 -0400 Received: from smtp.osdl.org ([65.172.181.4]:56737 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932323AbWJIHkr (ORCPT ); Mon, 9 Oct 2006 03:40:47 -0400 Date: Mon, 9 Oct 2006 00:40:14 -0700 From: Andrew Morton To: Heiko Carstens Cc: Jeff Garzik , Cornelia Huck , Greg KH , Ashok Raj , Nathan Lynch , linux-kernel@vger.kernel.org Subject: Re: [patch 1/2] sysfs: allow removal of nonexistent sysfs groups. Message-Id: <20061009004014.11ed8df2.akpm@osdl.org> In-Reply-To: <20061009072920.GB6936@osiris.boeblingen.de.ibm.com> References: <20061004130554.GA25974@havoc.gtf.org> <20061004172434.1a2ddb71@gondolin.boeblingen.de.ibm.com> <20061005081705.GA6920@osiris.boeblingen.de.ibm.com> <4524E983.6010208@garzik.org> <20061005124848.GB6920@osiris.boeblingen.de.ibm.com> <45250161.4060002@garzik.org> <20061005131623.GC6920@osiris.boeblingen.de.ibm.com> <20061009072920.GB6936@osiris.boeblingen.de.ibm.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 39 On Mon, 9 Oct 2006 09:29:20 +0200 Heiko Carstens wrote: > From: Heiko Carstens > > This patch makes it safe to call sysfs_remove_group() with a name group > that doesn't exist. Needed to make fix cpu hotplug stuff in topology code. > Surely an attempt to remove a non-existent entry is a bug, and this (racy-looking) patch just covers that up? > --- > fs/sysfs/group.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletion(-) > > Index: linux-2.6/fs/sysfs/group.c > =================================================================== > --- linux-2.6.orig/fs/sysfs/group.c 2006-10-09 09:15:25.000000000 +0200 > +++ linux-2.6/fs/sysfs/group.c 2006-10-09 09:25:23.000000000 +0200 > @@ -68,9 +68,12 @@ > { > struct dentry * dir; > > - if (grp->name) > + if (grp->name) { > + if (!sysfs_dirent_exist(kobj->dentry->d_fsdata, grp->name)) > + return; > dir = lookup_one_len(grp->name, kobj->dentry, > strlen(grp->name)); > + } > else > dir = dget(kobj->dentry); > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/