Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2135171pxf; Sat, 27 Mar 2021 03:34:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhuE+8YTWtBiSXYSCMp5fb7iCtbdkR8mWe2cYKTUBEnlyIQXu0a3KxzZHbl3oFrSnOhZsT X-Received: by 2002:a17:906:16ca:: with SMTP id t10mr19963846ejd.85.1616841294331; Sat, 27 Mar 2021 03:34:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616841294; cv=none; d=google.com; s=arc-20160816; b=iH1F/qKp+i2/w6j5iekX2oIODAU4CLimj42ZSfAIIzUCG/5OrGPV9LAL+TjRl1TkXB bQgADWBbh+AWBHw3uIHhNLwSb45YdvyvnPU09u3JjzkVlP9kVZSXwpFV9l1tHoQQxRYX IZm5ku/toP8c+tK8m7iUEdutGS42YdF4z7n5w/Q34pVaNe5nmenqXnbxdGwBQVy7okwi YP7qkW70yV1Jfw66AlGCp7tPwObLLPvlr/m5SFO8IAs2SUzx6K2DScxYkn/QCZF6/6n/ 6Z6frSNU3XrtZYbKuIEMXjJ9Hf5587nusdKr+F24KkqmyUmZeJE/2nVhOstBZ69LsS7U Pphw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=qkJwXnhItU3kFG/T3HJB3slerOlcFaj0wRngAYxoCag=; b=t30+DBEdY4P4F2aH7LCa6MjjBKUuVGFXrRjfTVD48g8ZawTth4S6FpDIMDIf4h9WWy pHv+oS5Q6gV4OzIHe+9yc4muC9Wdr6Kq4uEG6wvhgBux/OFFA1eqKJUwsUugrGq2UVLQ JOgEyMY0W1SSNYhCzjwW+5JgtVKaMMb2ngjnu3uBgLW3ibQMpEFfveSVED9blxPAEcrm 3wp8of9tecSO3BWZPlJ7jGqpaj37Da3HQNU5AzxDLp71cjMBjgcFNlgLISKjOA+W57hM P2kq1KcrHz+9H7GJSLnCdK4KGwvYme9+O5nacUQ5NFQ3iVtnKiEjuebpZjypLBUxxkE1 YozA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si8906184edq.597.2021.03.27.03.34.32; Sat, 27 Mar 2021 03:34:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbhC0KcY (ORCPT + 99 others); Sat, 27 Mar 2021 06:32:24 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:15362 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbhC0KcY (ORCPT ); Sat, 27 Mar 2021 06:32:24 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F6w8F72xGz8yBB; Sat, 27 Mar 2021 18:30:05 +0800 (CST) Received: from mdc.localdomain (10.175.104.57) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Sat, 27 Mar 2021 18:32:00 +0800 From: Huang Guobin To: , Hauke Mehrtens , "David S. Miller" , Jakub Kicinski CC: , Subject: [PATCH net-next v2] net: lantiq: Remove redundant dev_err call in xrx200_probe() Date: Sat, 27 Mar 2021 18:31:51 +0800 Message-ID: <1616841111-8722-1-git-send-email-huangguobin4@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.175.104.57] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/ethernet/lantiq_xrx200.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c index 51ed8a54d380..0f8ef8f1232c 100644 --- a/drivers/net/ethernet/lantiq_xrx200.c +++ b/drivers/net/ethernet/lantiq_xrx200.c @@ -460,10 +460,8 @@ static int xrx200_probe(struct platform_device *pdev) } priv->pmac_reg = devm_ioremap_resource(dev, res); - if (IS_ERR(priv->pmac_reg)) { - dev_err(dev, "failed to request and remap io ranges\n"); + if (IS_ERR(priv->pmac_reg)) return PTR_ERR(priv->pmac_reg); - } priv->chan_rx.dma.irq = platform_get_irq_byname(pdev, "rx"); if (priv->chan_rx.dma.irq < 0)