Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2138254pxf; Sat, 27 Mar 2021 03:39:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxym/sJnlr5TS2tsImUpJujQZoahbGmCIkVBiTBLD9l7DsVcycdI8x1gz3B3LmjSMcZliO7 X-Received: by 2002:aa7:dc0b:: with SMTP id b11mr19947967edu.124.1616841567644; Sat, 27 Mar 2021 03:39:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616841567; cv=none; d=google.com; s=arc-20160816; b=oFErL7yKLRwMRWiPfiEzcd/2j184TnEcdF2IOSY8fXkG3OVFO+EcAJo+glfs1H912s 1c8EkOH7A0CUqiBtLCOXwfL0SlYW1i7oSU3qCczcjJ6+PABGgURs303yaWBdE6gPImVk 2rNqx4vYFn/zqNRfZMI1zsFG1EDUruFAOGe4FOnFUQcKcufAY4kFIdLGgPRvHrlCOHvz yXvVbFj6bNTfMZ3SCp81XgSTywApsB8UqqaBsZ9VYfudbOguFVBvh3k39i0LhhHepMuG SZEvHPcnPpTftGaqhgKApeq12onjcjIuqQsIyI3dCy/BX7imHkYhuGx3dpgzfhrMEvkQ gudw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=HSVeuGJOynttDNdre4Ce/N082T5q7RsEgBySi3kyu00=; b=LuBtkXp71jM0mhMYbnclnE3MK6cGGhe2ZkueGtCanFL5tDL5KoEJrTKm2DaQfPth3Q chM67GA/FxX606byLo5ZPoB7eUtPXNRSzUuhgTHPb3+LDBtx8HiLFg16aTdtIXhrbhzJ XsWxtumUVGSBFqgHadENyOv7eyBiiDRG1QRfNJXyqMeR7DB3YWRwC2ff8srb/araFhEx FYZK/J+ZBLgk90y3AIedO03+6KWQUB4v4PG6cEkssYW0ju8IBY5y7a/tJowYUL8sEorP mk9dywLLg+qBYwPKyiC38bn8RBjz6bFuGFh+XDQdqP2QQ5LTtqqLTHJTCPeio48GeRMQ gCEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r18si8813523edw.69.2021.03.27.03.39.05; Sat, 27 Mar 2021 03:39:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231298AbhC0KiT (ORCPT + 99 others); Sat, 27 Mar 2021 06:38:19 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:14501 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbhC0KiS (ORCPT ); Sat, 27 Mar 2021 06:38:18 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4F6wHL3tqkzrbyb; Sat, 27 Mar 2021 18:36:14 +0800 (CST) Received: from mdc.localdomain (10.175.104.57) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Sat, 27 Mar 2021 18:38:06 +0800 From: Huang Guobin To: , Jakub Kicinski , "David S. Miller" , Christophe JAILLET , Yunjian Wang CC: , Subject: [PATCH net-next v2] net: moxa: remove redundant dev_err call in moxart_mac_probe() Date: Sat, 27 Mar 2021 18:37:54 +0800 Message-ID: <1616841474-9299-1-git-send-email-huangguobin4@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.175.104.57] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/ethernet/moxa/moxart_ether.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index 49fd843c4c8a..b85733942053 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -485,7 +485,6 @@ static int moxart_mac_probe(struct platform_device *pdev) ndev->base_addr = res->start; priv->base = devm_ioremap_resource(p_dev, res); if (IS_ERR(priv->base)) { - dev_err(p_dev, "devm_ioremap_resource failed\n"); ret = PTR_ERR(priv->base); goto init_fail; }