Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 27 Mar 2021 21:02:04 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Syed Nayyar Waris <syednwaris@gmail.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Robert Richter <rrichter@marvell.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Zhang, Rui" <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amit.kucheria@verdurent.com>,
        Linux-Arch <linux-arch@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value
 and _set_value
Message-ID: <YF8evJTkiBYjnDON@shinobu>
References: <cover.1615038553.git.syednwaris@gmail.com>
 <4c259d34b5943bf384fd3cb0d98eccf798a34f0f.1615038553.git.syednwaris@gmail.com>
 <CAHp75VfJ5bGaPkai_adsBoT6=7nS2K8ze0ka3gzZkQARkM5evA@mail.gmail.com>
 <CACG_h5pb0pA+cTNPGircAM3UrV5BGmqgk45LF_9phU_J4FaRyw@mail.gmail.com>
 <CAHp75VfDZbJjCOEGdHc=-D6W8_7m2=CinXj-itwn6hvoVqdWYQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="U8fuNQh2GYN2BerP"
Content-Disposition: inline
In-Reply-To: <CAHp75VfDZbJjCOEGdHc=-D6W8_7m2=CinXj-itwn6hvoVqdWYQ@mail.gmail.com>
Precedence: bulk


--U8fuNQh2GYN2BerP
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote:
> On Saturday, March 27, 2021, Syed Nayyar Waris <syednwaris@gmail.com> wro=
te:
>=20
> > On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > >
> > > On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris <syednwaris@gmail.co=
m>
> > wrote:
> > >
> > > > +       bitmap_set_value(old, 64, state[0], 32, 0);
> > > > +       bitmap_set_value(old, 64, state[1], 32, 32);
> > >
> > > Isn't it effectively bitnap_from_arr32() ?
> > >
> > > > +       bitmap_set_value(new, 64, state[0], 32, 0);
> > > > +       bitmap_set_value(new, 64, state[1], 32, 32);
> > >
> > > Ditto.
> > >
> > > --
> > > With Best Regards,
> > > Andy Shevchenko
> >
> > Hi Andy,
> >
> > With bitmap_set_value() we are also specifying the offset (or start)
> > position too. so that the remainder of the array remains unaffected. I
> > think it would not be feasible to use bitmap_from/to_arr32()  here.
>=20
>=20
> You have hard coded start and nbits parameters to 32. How is it not the
> same?

Would these four lines become something like this:

	bitmap_from_arr32(old, state, 64);
	...
	bitmap_from_arr32(new, state, 64);

Sincerely,

William Breathitt Gray

--U8fuNQh2GYN2BerP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmBfHrMACgkQhvpINdm7
VJIQVg//bgl/dKfym1/4ndQLg+79vTreGgUHlj9VHg6VMMpGBC5c0d/M5WlBKEiC
jMZAd8mW61HunaeUShz7s9pUh8qbdGGSdNk1DvtAv/A4ouJhUxzmChjXRtd7OhS5
EpgNqEykCO5DJIaloltUabGk4ds5S+L+cFfLHwQsFMrrE+gFdADfiPziDanNVExM
1q+dxTml+/rl6g0L6oX3hnN17Et/p1mggRx1MC8Tnn5dQlEz9MIqT1OY0iKhdiuF
ruiOgQqO7zQWYzQzIH+SehA3wSLu5Y/uiQMEWS1wAWH7Ep44cmhMaj5P+f2tx8Wr
Q7CHT0SF01lgS7MKR48J1ClXGeLL9ae4Iw1t3SS9zl1obUYWdvwWHGaKmFmIzapv
+r+KF4sJFaDT42pSolIfQUQN4qBNZwJbVyU2URxwZEPBvuO9lgGbmZ1TFKNlZvPt
+L27a74cmk/iRKKJtTWLsSnEnGcQ2jLBW4L06Luw0aSDC8YlHFHPB8PbME8V0SR7
5MhOFaoupDeyU4j1rQddZHJg/FvEpu0Vm1pL/8ZWuHKnVm6PzSxkzggmW0dAasrq
bfYIlZqYMWzB+QNoIRZcI1D3BMLwDBsoLx+HjZ0S7fwEfYO1Z+l34pXazdXKGkNN
EbF1yuJQD55Si4RSPDDArnJEKJ/FJ1lxALGklpco/80gCLvtJ8M=
=oqqt
-----END PGP SIGNATURE-----

--U8fuNQh2GYN2BerP--