Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932353AbWJIIFs (ORCPT ); Mon, 9 Oct 2006 04:05:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932366AbWJIIFs (ORCPT ); Mon, 9 Oct 2006 04:05:48 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:47877 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S932353AbWJIIFr (ORCPT ); Mon, 9 Oct 2006 04:05:47 -0400 Date: Mon, 9 Oct 2006 10:05:42 +0200 From: Adrian Bunk To: Michael Krufky Cc: Linus Torvalds , v4l-dvb-maintainer@linuxtv.org, Linux Kernel Mailing List Subject: Re: [v4l-dvb-maintainer] 2.6.19-rc1: DVB frontend selection causes compile errors Message-ID: <20061009080542.GE3172@stusta.de> References: <20061009003146.GA3172@stusta.de> <4529FFDC.5080708@linuxtv.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4529FFDC.5080708@linuxtv.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2228 Lines: 73 On Mon, Oct 09, 2006 at 03:53:00AM -0400, Michael Krufky wrote: > Adrian Bunk wrote: > > The DVB frontend selection changes in 2.6.19-rc1 are giving me the > > following compile error: > > > > <-- snip --> > > > > ... > > LD .tmp_vmlinux1 > > drivers/built-in.o: In function `dvb_init': > > saa7134-dvb.c:(.text+0x91d94): undefined reference to `tda10086_attach' > > saa7134-dvb.c:(.text+0x91db0): undefined reference to `tda826x_attach' > > make: *** [.tmp_vmlinux1] Error 1 > > > > <-- snip --> > > > > .config attached. > > > > cu > > Adrian > > > Adrian, Hi Michael, > Does this fix it for you? it does fix it with my .config, but > Signed-off-by: Michael Krufky > > diff -r 7efa405e2d66 linux/drivers/media/dvb/frontends/tda10086.h > --- a/drivers/media/dvb/frontends/tda10086.h Fri Oct 06 17:12:00 2006 -0300 > +++ b/drivers/media/dvb/frontends/tda10086.h Mon Oct 09 03:43:28 2006 -0400 > @@ -35,7 +35,16 @@ struct tda10086_config > u8 invert; > }; > > +#if defined(CONFIG_DVB_TDA10086) || defined(CONFIG_DVB_TDA10086_MODULE) > extern struct dvb_frontend* tda10086_attach(const struct tda10086_config* config, > struct i2c_adapter* i2c); > +#else > +static inline struct dvb_frontend* tda10086_attach(const struct tda10086_config* config, > + struct i2c_adapter* i2c) > +{ > + printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __FUNCTION__); > + return NULL; > +} > +#endif // CONFIG_DVB_TDA10086 >... this breaks with CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA1004X=m. #if defined(CONFIG_DVB_TDA10086) || (defined(CONFIG_DVB_TDA10086_MODULE) && defined(MODULE)) might work, but the whole manual frontend selection IMHO looks a bit fragile. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/