Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2333483pxf; Sat, 27 Mar 2021 08:32:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1kAQHVqnihczEtP1wQC/VSj+yPzg8J76yHNXCc+ADIq8JV7wjxSISfiIhpNDgiL7F2iOO X-Received: by 2002:a50:fd83:: with SMTP id o3mr21460345edt.90.1616859135557; Sat, 27 Mar 2021 08:32:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616859135; cv=none; d=google.com; s=arc-20160816; b=NqhL7JVEGOoXHeQeB3R3hp88kYDwiWDM3zTNwiquFYGow+Eg82nbLedY8pdHyZKdqt aFkc7h13bCVgfgW/VTCPjZPRr2HdbaW8B0TUyXckD5/kFK4RCAqTNruK2ftUQk4+FzPK 5vzxFQj4fpqMs0VzU+gI2htVf55L31ulJKPXmLsD34CtR+ENt1S58wcguSnWrtepwP3D zUob0uFBH7beloWnisp4Gihcc4M86KVeGwCs5v3R0c88mldjmK3E154PU6XIjYiWF2UI 0MGpQmRHmcMpllwrZTSg2U8Eb5OSM1wo/K4H3au+z8mE8seFLF+xB3OUIPJFtK4bmacD 8h0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=EHcwXqUrSTruk5dtsQHSj2xc6JILZtX1/kO+lE4c9F0=; b=F2MNpxXJ9DFaSAXW+W/wB3NOKoxpQH66rRlfz2N4cfuJ2sIFz14FU/0H5HX3aKaSXX hU4G0W8xAER2BfEkPtX8CRDjFoD6BdcOeqM+xNRTV/saiC2TOHOD1ZspNToouGsmU+kT nzlIRGMoPrWR8asg2Q6YJCwLQeVieqphaopflDrSS2pior0zHNK3motrQF8pQrkcSaqV hWhgYTwxnvHD+SPg1cTbdxaHsUeOa4cCBOoO0WQQTBXBY9bDa/Jy+xVPC6wUgLy8w6YI jRSavJTE2b0QBWXwTc+0PK651BYfRLwMTcma6+o0e4hiedqph7ymuiCsaA4SfxByK9Hh TFlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lh6si9143746ejb.613.2021.03.27.08.31.52; Sat, 27 Mar 2021 08:32:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbhC0P0o (ORCPT + 99 others); Sat, 27 Mar 2021 11:26:44 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51132 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbhC0P0I (ORCPT ); Sat, 27 Mar 2021 11:26:08 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lQAp3-00DLWU-Jx; Sat, 27 Mar 2021 16:25:57 +0100 Date: Sat, 27 Mar 2021 16:25:57 +0100 From: Andrew Lunn To: Don Bollinger Cc: 'Jakub Kicinski' , arndb@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, brandon_chuang@edge-core.com, wally_wang@accton.com, aken_liu@edge-core.com, gulv@microsoft.com, jolevequ@microsoft.com, xinxliu@microsoft.com, 'netdev' , 'Moshe Shemesh' Subject: Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS Message-ID: References: <009601d72023$b73dbde0$25b939a0$@thebollingers.org> <011301d7226f$dc2426f0$946c74d0$@thebollingers.org> <011901d7227c$e00015b0$a0004110$@thebollingers.org> <011c01d72284$544c8f50$fce5adf0$@thebollingers.org> <012b01d7228f$a2547270$e6fd5750$@thebollingers.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <012b01d7228f$a2547270$e6fd5750$@thebollingers.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > What I have works. Your consumers get quirk handling, mine don't need it. > No compromise. Hi Don All this discussion is now a mute point. GregKH has spoken. But i'm sure there are some on the side lines, eating popcorn, maybe learning from the discussion. Would you think it is O.K. to add a KAPI which works for 3 1/2" SCSI disks, but not 2", because you only make machines with 3 1/2" bays? This is an extreme, absurd example, but hopefully you get the point. We don't design KAPIs with the intention to only work for a subset of devices. It needs to work with as many devices as possible, even if the first implementation below the KAPI is limited to just a subset. Anyway, i'm gratefull you have looked at the new ethtool netlink KAPI. It will be better for your contributions. And i hope you can make use of it in the future. But i think this discussion about optoe in mainline is over. Andrew