Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/3] scsi: add runtime PM workaround for SD cardreaders
To:     Martin Kepplinger <martin.kepplinger@puri.sm>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stern@rowland.harvard.edu
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210112093329.3639-1-martin.kepplinger@puri.sm>
 <9d0042fbfba9d33315f9eee7448b60aca8949431.camel@puri.sm>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <147104aa-1040-3632-6fed-9e6c584c3561@acm.org>
Date:   Sat, 27 Mar 2021 09:01:37 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <9d0042fbfba9d33315f9eee7448b60aca8949431.camel@puri.sm>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/27/21 3:48 AM, Martin Kepplinger wrote:
> since this is absolutely needed for runtime pm with the SD device we
> use I assume there are others that would benefit from this too. Do you
> have any concerns or thoughts about this (logic and interface)?

Hi Martin,

Since the issue addressed by this patch series concerns a controller
bug, please use the SCSI core BLIST mechanism instead of introducing a
new sysfs attribute. A sysfs attribute could be misconfigured. BLIST
attributes however are set from inside the kernel and hence do not need
help from userspace. See e.g. c360652006bb ("scsi: devinfo:
BLIST_RETRY_ASC_C1 for Fujitsu ETERNUS").

Thanks,

Bart.