Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1615038553.git.syednwaris@gmail.com> <4c259d34b5943bf384fd3cb0d98eccf798a34f0f.1615038553.git.syednwaris@gmail.com>
 <CAHp75VfJ5bGaPkai_adsBoT6=7nS2K8ze0ka3gzZkQARkM5evA@mail.gmail.com>
 <CACG_h5pb0pA+cTNPGircAM3UrV5BGmqgk45LF_9phU_J4FaRyw@mail.gmail.com>
 <CAHp75VfDZbJjCOEGdHc=-D6W8_7m2=CinXj-itwn6hvoVqdWYQ@mail.gmail.com> <YF8evJTkiBYjnDON@shinobu>
In-Reply-To: <YF8evJTkiBYjnDON@shinobu>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 27 Mar 2021 18:35:40 +0200
Message-ID: <CAHp75VektkxSH7S3qTkYd1De613HGrBDvXn36FFex_p1n9BDng@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value
To:     William Breathitt Gray <vilhelm.gray@gmail.com>
Cc:     Syed Nayyar Waris <syednwaris@gmail.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Robert Richter <rrichter@marvell.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Zhang, Rui" <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amit.kucheria@verdurent.com>,
        Linux-Arch <linux-arch@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Mar 27, 2021 at 2:02 PM William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote:
> > On Saturday, March 27, 2021, Syed Nayyar Waris <syednwaris@gmail.com> wrote:
> > > On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:
> > > > On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris <syednwaris@gmail.com>
> > > wrote:
> > > >
> > > > > +       bitmap_set_value(old, 64, state[0], 32, 0);
> > > > > +       bitmap_set_value(old, 64, state[1], 32, 32);
> > > >
> > > > Isn't it effectively bitnap_from_arr32() ?
> > > >
> > > > > +       bitmap_set_value(new, 64, state[0], 32, 0);
> > > > > +       bitmap_set_value(new, 64, state[1], 32, 32);
> > > >
> > > > Ditto.

> > > With bitmap_set_value() we are also specifying the offset (or start)
> > > position too. so that the remainder of the array remains unaffected. I
> > > think it would not be feasible to use bitmap_from/to_arr32()  here.
> >
> >
> > You have hard coded start and nbits parameters to 32. How is it not the
> > same?
>
> Would these four lines become something like this:
>
>         bitmap_from_arr32(old, state, 64);
>         ...
>         bitmap_from_arr32(new, state, 64);

This is my understanding, but I might miss something. I mean driver
specifics that make my proposal incorrect.

-- 
With Best Regards,
Andy Shevchenko