Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1616831193-17920-1-git-send-email-tanxiaofei@huawei.com>
 <1616831193-17920-7-git-send-email-tanxiaofei@huawei.com> <CAHp75Vd0hVqsfsZK=d1dz98Kbchqz-w4RqQQp6FwisxSGG5BzA@mail.gmail.com>
 <50e838ca74c56b9fd5cbbc2d7234829f0e0b4131.camel@perches.com>
In-Reply-To: <50e838ca74c56b9fd5cbbc2d7234829f0e0b4131.camel@perches.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 27 Mar 2021 18:39:56 +0200
Message-ID: <CAHp75Vcr5DTiQ=WWSC+Ch-jEw7H+f13A=4=U3QVF5ttvRr1D7w@mail.gmail.com>
Subject: Re: [PATCH v2 06/15] ACPI: LPSS: fix some coding style issues
To:     Joe Perches <joe@perches.com>
Cc:     Xiaofei Tan <tanxiaofei@huawei.com>,
        "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "rui.zhang@intel.com" <rui.zhang@intel.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linuxarm@openeuler.org" <linuxarm@openeuler.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Mar 27, 2021 at 3:39 PM Joe Perches <joe@perches.com> wrote:
>
> On Sat, 2021-03-27 at 10:19 +0200, Andy Shevchenko wrote:
> > On Saturday, March 27, 2021, Xiaofei Tan <tanxiaofei@huawei.com> wrote:
> >
> > > Fix some coding style issues reported by checkpatch.pl, including
> > > following types:
> > >
> > > WARNING: simple_strtol is obsolete, use kstrtol instead
> >
> >
> > And one more thing, the above message is bogus. Read what the comments in
> > the code says about use cases for simple_*() vs. kstrto*() ones.
> >
> > Joe?
>
> This check and message is nearly 10 years old and was appropriate for
> when it was implemented.
>
> kernel.h currently has:
>  * Use these functions if and only if you cannot use kstrto<foo>, because
>
> So the message could be changed to something like:
>
> WARNING: simple_strtol should be used only when kstrtol can not be used.

Fine with me, thanks!

-- 
With Best Regards,
Andy Shevchenko