Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 27 Mar 2021 11:01:53 -0600
From:   Rob Herring <robh@kernel.org>
To:     Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Cc:     jic23@kernel.org, michal.simek@xilinx.com, lars@metafoo.de,
        pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        git@xilinx.com
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add ti,ina260.yaml
Message-ID: <20210327170153.GA243988@robh.at.kernel.org>
References: <20210322105056.30571-1-raviteja.narayanam@xilinx.com>
 <20210322105056.30571-2-raviteja.narayanam@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210322105056.30571-2-raviteja.narayanam@xilinx.com>
Precedence: bulk

On Mon, Mar 22, 2021 at 04:20:55PM +0530, Raviteja Narayanam wrote:
> Add a binding for Texas Instruments INA260 power monitor device.
> 
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
> ---
>  .../bindings/iio/adc/ti,ina260.yaml           | 57 +++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ina260.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ina260.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ina260.yaml
> new file mode 100644
> index 000000000000..97c68188e53d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ina260.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ina260.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments INA260 power monitor
> +
> +maintainers:
> +  - Raviteja Narayanam <raviteja.narayanam@xilinx.com>
> +
> +description: |
> +  The INA260 is a digital-output, current, power and voltage monitor
> +  with an I2C and SMBUS compatible interface with an integrated shunt
> +  resistor. It features up to 16 programmable addresses on I2C compatible
> +  interface. Datasheet - https://www.ti.com/lit/ds/symlink/ina260.pdf?ts=1608607288391
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,ina260
> +
> +  reg:
> +    description: |
> +      The 7-bits long I2c address of the device

Just 'maxItems: 1'

> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +  interrupts:
> +    description: |
> +      IRQ line for the device

That's every 'interrupts' property. Drop.

You need to say how many: maxItems: 1

> +
> +  label:
> +    description: |
> +      A symbolic name for the device
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#io-channel-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ina260@40 {
> +        compatible = "ti,ina260";
> +        reg = <0x40>;
> +        #io-channel-cells = <1>;
> +      };
> +    };
> +...
> -- 
> 2.17.1
>