Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2523557pxf;
        Sat, 27 Mar 2021 14:29:01 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx2KHV8vep/j5tbuH1yasUvt/Pm2XPKr79GayGm8jrRx41c3fRTF6nbh5X1NF9b49K/GYey
X-Received: by 2002:a17:906:5495:: with SMTP id r21mr21999437ejo.471.1616880541772;
        Sat, 27 Mar 2021 14:29:01 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1616880541; cv=none;
        d=google.com; s=arc-20160816;
        b=t+AM4TdJwUdusxe+VlQJgSFt74OUC+bDllL0B1lNZ7V3ZWRfyosgCP47IritZCWLUZ
         PkEm0Qd64+xApUyE7r+p//2w9Q0lR3rB4Gi+j7hB9VUJ8vGxEMI+CE3IabO4uJKROmgC
         dIoNB3CYXf9AMh5fVrnRFYghyW2oPeiEkHvNky0Fz9igZ8udjUFg5C2t2AfPloPAhJ3X
         EP0WAN3/nRkvt490A+I44Kw3F89wa9hfKOWI97qyeVUNfPl+1D/J0vTse5/f4aLm5xBq
         koKRokinMt2zgUf4hMUwM0Nnwol4UnfVW+2Bdtgt1oaI72ODbPlORAtU6OABKodd+p9C
         Z6CA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version;
        bh=SBtaiNE0wjxa5FEEbUoLsKR69z5Xrq4YqHEGvy8x/OU=;
        b=k7+MTjR4YNxnOY7+jC9an/O3ujwvb02pILV2brk1FfALge82HZ4KtFYVPvXg6D1VoX
         eyP0IboLfsFrjluYRyTjuc+Z7UIPkMXP/4Pbc5am0O8V/lQepZlrhWfL30SLNuOU/xvv
         Yf5rBoWwa/+A3zT2yz2U/aky97++nQ2BWIqN5h9p2QmcCX47e/eSNJ8e708l4eL6Wff0
         9KxAl8q5ujkzV+DKPGZSj6WRvr07ztAV/ASgZIgTgiGc+EH7r7llkIINIibLX4TT9he6
         PM9w7KIM2tFPrqkOCf6mywZUE1FOUeh8EVM1+O+ErdHIJiqWdGj6UdhjK29ZiGuynnZV
         W8nw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id ko14si9341215ejc.419.2021.03.27.14.28.39;
        Sat, 27 Mar 2021 14:29:01 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230496AbhC0VZ7 (ORCPT <rfc822;maguicai@gmail.com> + 99 others);
        Sat, 27 Mar 2021 17:25:59 -0400
Received: from mout.kundenserver.de ([217.72.192.73]:47085 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230483AbhC0VZb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 27 Mar 2021 17:25:31 -0400
Received: from mail-ot1-f53.google.com ([209.85.210.53]) by
 mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis)
 id 1MadGG-1lwa2s3ODS-00c9Tm; Sat, 27 Mar 2021 22:25:29 +0100
Received: by mail-ot1-f53.google.com with SMTP id t23-20020a0568301e37b02901b65ab30024so8630852otr.4;
        Sat, 27 Mar 2021 14:25:28 -0700 (PDT)
X-Gm-Message-State: AOAM531N3hezseYPihghKyTUNAp/DKWstgZHN+W6rhlId/6Lw0VMOnM6
        8CiQFJlgahi/o2Ar1AJEO4J5jGC81DQ9a0ovG10=
X-Received: by 2002:a9d:316:: with SMTP id 22mr17117443otv.210.1616880327372;
 Sat, 27 Mar 2021 14:25:27 -0700 (PDT)
MIME-Version: 1.0
References: <1616868399-82848-1-git-send-email-guoren@kernel.org> <1616868399-82848-3-git-send-email-guoren@kernel.org>
In-Reply-To: <1616868399-82848-3-git-send-email-guoren@kernel.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Sat, 27 Mar 2021 22:25:12 +0100
X-Gmail-Original-Message-ID: <CAK8P3a0FG3cpqBNUP7kXj3713cMUqV1WcEh-vcRnGKM00WXqxw@mail.gmail.com>
Message-ID: <CAK8P3a0FG3cpqBNUP7kXj3713cMUqV1WcEh-vcRnGKM00WXqxw@mail.gmail.com>
Subject: Re: [PATCH v4 2/4] riscv: cmpxchg.h: Merge macros
To:     Guo Ren <guoren@kernel.org>
Cc:     linux-riscv <linux-riscv@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-csky@vger.kernel.org,
        linux-arch <linux-arch@vger.kernel.org>,
        Guo Ren <guoren@linux.alibaba.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Michael Clark <michaeljclark@mac.com>,
        Anup Patel <anup@brainfault.org>,
        Palmer Dabbelt <palmerdabbelt@google.com>
Content-Type: text/plain; charset="UTF-8"
X-Provags-ID: V03:K1:TiYln5qFCOjdYjLSSooDgnD1CnhaEYM4hRCyz0I+t6bEWNBHqFN
 Naw0TyLHp+5giR3FFzr8E+okwipr5J38scviWbYwZYAC3PyyftZlORE+DySKinvLH28BoiC
 TLiMml9cyrVrupiHC5vAJQDQ9OnFFokPsAdaMq/aPflF42aPVVbXCiPe+lAYHn+OyBIWWNV
 MtmRKHOQLFaWd5ZbUfbsQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:c5QrygU0lWE=:tLSca2w+CRbY0qN+pZQbb7
 TUTIwmfs3/TKFavbq5pPI5zmoInvl9pgxFS0FwgCsipUtGDEbnCF45hpo5Smyp+ZCbg7VC8Q8
 2ApFumPqegqHlg65NPONJn4Imtxrg0CDtAYXzlAtrspK473NW0Kwi166ej8jXUBRj9+qQKEjw
 cRAaBt7VBdrD+98gtRl7wyqxWzESWuenmzuzCZyn0v3dQ98IkMm1aZ5Kn8IsBa00z3ZstUUc6
 78P7zyvPgLINHrSad5z8jWae3LTaV2UfnRUpRnyseRY6wgDskzv/jAY6zKuqxKVHY4DGdoUSr
 Gelt4+4+74iwbnFgdMD8HOXJVoBJCnnvr+EVZiH4IL1hkK8IDWTAymOCq93x3J/XNJ82JiuF2
 4Et38SBDKbmbzW61Reh2VSQVh0tm3HB1CUUOoLUGLMwTEgx/+O+D+c9zQiYa6Z7LT+ObkW9u0
 6ESzrzYz699KG5ibfgICCEGNqYaodJo=
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 27, 2021 at 7:06 PM <guoren@kernel.org> wrote:
>
> From: Guo Ren <guoren@linux.alibaba.com>
>
> To reduce assembly codes, let's merge duplicate codes into one
> (xchg_acquire, xchg_release, cmpxchg_release).
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>

This is a nice cleanup, but I wonder if you can go even further by using
the definitions from atomic-arch-fallback.h like arm64 and x86 do.

        Arnd