Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2722405pxf; Sat, 27 Mar 2021 23:36:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4YigppapxHHMTPqK0onGnxcCRD0lk2xXO+TmrTD6r7XTCJPFgeqwvpFZ6ww78vxc/EUAn X-Received: by 2002:a17:907:94cc:: with SMTP id dn12mr23218468ejc.177.1616913374545; Sat, 27 Mar 2021 23:36:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616913374; cv=none; d=google.com; s=arc-20160816; b=boW69uVhpnHYqntuVeYyl+BeEYS9TC9JfBkXK0p5Ih6vD2HNVtCu+1LFoKNQjCOqgA zd+EJ3Bz2aDUOkxrGlN57DNPYdVY0rjX2WyszL8eua28EjU6VkGmQw6MUxdlDg1rXYG0 LICa5o5Zn4O66ThS93OVNH5uBL0ELKAYERjusIH5ASKhH5Mjo6oK6XRotRoKFplxb7DX uAli5ED8IYmCoN7eqdIcdRNfJSv7RZP3h4BWkQqyrhPHI5Qqd50SXMoQg0Num+WSa3m/ ZUhKSzWcqBUxSgMCB3juRsrbkMigajjiYWTd2OOLSaFN269e+fshjfVWpApvY664wpdL hw7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=ST/Q4P4e3zWtDEs7+6ES57ggpPEbDVFpalF1X5n9dEA=; b=I+e9wcQiwCOKEF6ndv7hVi65UhaYId9dOoTp1q998sUrAX1OeNBZtomifZRV/25snd VXZtI0LdpynUYUhMPDaABPVzmrRN3UVqxFcMpOl1AFINbVp1TSl53FnZ86HG0oK0YBP7 8WPz/7A++/Fc3jnTP3m8WoP81eQabmpu/44KD87Ndg1e5N07CfWBukS3P90tSGPG2VUX YbKFBxg92kC1QDpzlkOm/cNALDti5DayBb8zrNhedzK/TkyaEUMWmvbOu2EyMyPqVGER XX8pgGHa+i1UPwk29oxOvg8UxjEYMfG/S28rZCqweliUWJcrwCvZaNp5Jt59I1Tk4jLM LZ2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TZ3ei7zB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pg2si10242837ejb.233.2021.03.27.23.35.37; Sat, 27 Mar 2021 23:36:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TZ3ei7zB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbhC1GbV (ORCPT + 99 others); Sun, 28 Mar 2021 02:31:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:56672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbhC1GbR (ORCPT ); Sun, 28 Mar 2021 02:31:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A43E36197C; Sun, 28 Mar 2021 06:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616913076; bh=fIYmtiiVahTZKgHaQD+jDuMxYY5AvOy62Q+boojOK1E=; h=From:To:Cc:Subject:Date:From; b=TZ3ei7zBeAgVBpKeSMgUIfT7cFEsCeH1gjJAc1Xka+xh1tEnN6M+Juhcxj4cMHSJ6 WmILreZnGkimmxPtbMXMLKfedRa/wD37UVBmGCsKO3FB75rnREvgypwcEkfIe51j4u /lAcvsk3EEHh9Hg1GmHcvDQb7ilTxctp3FsxA13LHoejLlR7k2ECSFxo9LF+OTle7G sS1dndQX+pK0CxgW0gsgWvaFbWNF+lH/vurb0mQGAd1dG3eq4gg6flYOpQa4HmQrua 0CR5asMfgeWZ1rL4qzvhyivvy1moujsSCNT4SCYn4sfSp0zU71oleIAtjphFxp9yb1 MVZVtA9yLHxfA== From: guoren@kernel.org To: guoren@kernel.org Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xtensa@linux-xtensa.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, Guo Ren Subject: [PATCH v5 0/7] riscv: Add qspinlock/qrwlock Date: Sun, 28 Mar 2021 06:30:21 +0000 Message-Id: <1616913028-83376-1-git-send-email-guoren@kernel.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guo Ren Current riscv is still using baby spinlock implementation. It'll cause fairness and cache line bouncing problems. Many people are involved and pay the efforts to improve it: - The first version of patch was made in 2019.1: https://lore.kernel.org/linux-riscv/20190211043829.30096-1-michaeljclark@mac.com/#r - The second version was made in 2020.11: https://lore.kernel.org/linux-riscv/1606225437-22948-2-git-send-email-guoren@kernel.org/ - A good discussion at Platform HSC.2021-03-08: https://drive.google.com/drive/folders/1ooqdnIsYx7XKor5O1XTtM6D1CHp4hc0p Hope your comments and Tested-by or Co-developed-by or Reviewed-by ... Let's kick the qspinlock into riscv right now (Also for the architecture which hasn't xchg16 atomic instruction.) Change V5: - Fixup #endif comment typo by Waiman - Remove cmpxchg coding convention patches which will get into a separate patchset later by Arnd's advice - Try to involve more architectures in the discussion Change V4: - Remove custom sub-word xchg implementation - Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 in locking/qspinlock Change V3: - Coding convention by Peter Zijlstra's advices Change V2: - Coding convention in cmpxchg.h - Re-implement short xchg - Remove char & cmpxchg implementations Guo Ren (6): locking/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 csky: Convert custom spinlock/rwlock to generic qspinlock/qrwlock powerpc/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 openrisc: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 sparc: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 xtensa: qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 Michael Clark (1): riscv: Convert custom spinlock/rwlock to generic qspinlock/qrwlock arch/csky/Kconfig | 2 + arch/csky/include/asm/Kbuild | 2 + arch/csky/include/asm/spinlock.h | 82 +-------------- arch/csky/include/asm/spinlock_types.h | 16 +-- arch/openrisc/Kconfig | 1 + arch/powerpc/Kconfig | 1 + arch/riscv/Kconfig | 3 + arch/riscv/include/asm/Kbuild | 3 + arch/riscv/include/asm/spinlock.h | 126 +----------------------- arch/riscv/include/asm/spinlock_types.h | 15 +-- arch/sparc/Kconfig | 1 + arch/xtensa/Kconfig | 1 + kernel/Kconfig.locks | 3 + kernel/locking/qspinlock.c | 46 +++++---- 14 files changed, 49 insertions(+), 253 deletions(-) -- 2.17.1