Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2780771pxf; Sun, 28 Mar 2021 01:53:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1pGhClsrisE4cY89zp96aLaL2RD+ulwEvJfJl8d9ZJ9ZYQBmfa9aJijv/94AUULkDQjvo X-Received: by 2002:aa7:db15:: with SMTP id t21mr23628225eds.145.1616921606457; Sun, 28 Mar 2021 01:53:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616921606; cv=none; d=google.com; s=arc-20160816; b=hm0+KydM+EPDRWWPcXEEoD/4sdwST56Q+jZjDXgi0MUzgYWN0R1freTso1XFv8cWSt VyPdD8+gkdInUSgnS9zJ6pmb+Z7RVuLYem8S+e8WQ+gAawtaJjL11iMwEPM/QXq69u+X KvCloeah60fSxQf81R6RpbUx22GUjGkmQsncZiU3gieJDcHLdCop08vFOVoXsRSruYJS +q6wT1h9YPZZ6GyX0ehiU1k+22ffZyF7jioDUcdGcObTKLUnRUWGKGbFADJg+nWkC8RS ffSEAyLG9mJfFex179By+gnkgl80Jt3R45UXaJ0pI+DQHmRBbNw1YJHDLHDSthrAs4eH ILwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cXLrJ2vrl4kf0N81wopgG4LgcTLak4VTcazIM7mlpwI=; b=zSrQmceAeNecCEbbqzIyCsQIQ+KRFsOXOsSmSOyiEOH8shyfOcFTN0mSV0BumacC18 hmojEJi7H9vxMBeJ3RIHFnQhrpOmrZvkaZKoymdAkUwDLkXk+zeF24R534mnlDF0vXzS YA/eAIv0QIRMWqJaR/shspE+L1uC1OB0A88id40nHDZ8EJ5apfJzE9+/UcbORhJUdvOV +nFDyIllSYdCbdNJwwRoQwYu02iQoIlGGRz5n4pAoBB9/W2s/t7haqbMu0VmW/7nWxnn Z9J8aJAmTFRGLN0eHHS0JBOr1s5Z7a2rJFwmngo3OGi0J7eOmBNP5VzIicaig7HTRjna RAIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XdLjCw4V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh28si10669107ejb.580.2021.03.28.01.53.03; Sun, 28 Mar 2021 01:53:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XdLjCw4V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230526AbhC1Ipq (ORCPT + 99 others); Sun, 28 Mar 2021 04:45:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:37910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbhC1Ipl (ORCPT ); Sun, 28 Mar 2021 04:45:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C2E376196C; Sun, 28 Mar 2021 08:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616921133; bh=3MfptsBDXUmNMmv4TO5l2srJOZ/R1fwboYZKKzF3mp4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XdLjCw4V448T8l6ky+w8KiNUISRGwRWXzlWaNEV1uhgiwRwpJTVFN+NsYiLxHuFUs 6eVbaE1k1Jqn99CJMNviWBXuribiWO9C8rMO1qyBiVdFOPzCuv18AEWLA9DuO4rSQO xYGqaY3ZM15+HWm9w81a+cU/XcwCE8qkeV28ksEA= Date: Sun, 28 Mar 2021 10:45:28 +0200 From: Greg KH To: Pavel Skripkin Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org, syzbot+bcc922b19ccc64240b42@syzkaller.appspotmail.com Subject: Re: [PATCH] tty: fix memory leak in vc_deallocate Message-ID: References: <20210327214443.21548-1-paskripkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210327214443.21548-1-paskripkin@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 28, 2021 at 12:44:43AM +0300, Pavel Skripkin wrote: > syzbot reported memory leak in tty/vt. > The problem was in VT_DISALLOCATE ioctl cmd. > After allocating unimap with PIO_UNIMAP it wasn't > freed via VT_DISALLOCATE, but vc_cons[currcons].d was > zeroed. > > Signed-off-by: Pavel Skripkin > Reported-by: syzbot+bcc922b19ccc64240b42@syzkaller.appspotmail.com > --- > drivers/tty/vt/vt.c | 1 + > 1 file changed, 1 insertion(+) Is this patch tested by syzbot to fix the problem? thanks, greg k-h