Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2855221pxf; Sun, 28 Mar 2021 04:16:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxGSNmfw4SUlie1LQBJwhCRw5INX9cRBm8B5sMlzBpZCP1hpFA9hG4vGHU795WRXjhAKbB X-Received: by 2002:a05:6402:5113:: with SMTP id m19mr24371711edd.78.1616930169963; Sun, 28 Mar 2021 04:16:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616930169; cv=none; d=google.com; s=arc-20160816; b=Y0JEJr1qLJ+Z8fHUOpZUuKLiCzTkBkCmEN3W5GMqXYc37A5Q3BbBsO+jU3rxuJXN0E KGmcc1Ovi1I1I45N+b0s18FJFKix/wawkgwy7BlOR4KkNMzt+bsyu1aYeb48RPEYCr7r TWptR1kYFQ/3jDGttlnoDNrVgqjU7FGTvGjxbOvu1KInrN4HOg/qpBKlaLjfJGjNNPp0 W2ZFOD6Sa7LaTK78BU6wZ6YlkCtdFnAup2cOaFGbwqnEcZoTam9FV4421cLGZQy/5BOI NuhliBFLPjhGON3PphKCAcP/b2TCU/azP99vEqtTDMfhBVpV6ZTMSIHrD5Xbwid1hthH oZTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dMugKNeoxcEHPCeiJkFpOtVsDqw5zqDVkVewPkt0e/I=; b=It6Kz0thdGc41hbxI8DwMmKcTVYO0S/6Al2enL/p5PU6+uZfdgV5IJIB2ET5mUGUdV 8f1Nh/lTt0GcjHWQUGwST6rLElmcn4TZqoWieuOeYCGIFkCfr+22iqMK1Po5vJmaAHNd 7BuDQCxUewGofeIjKPIeRlYVNPac95egEqdAB2dHlJ7pqM6QJ413h9g+nJHAXfokLFnw S2RU1lBjTQ7IGJEHYcV4apGLVA9AqfisNMk0Tk9lpJxAIvGlmbG6/9p/I30tIUpwJRB5 cmqWS5CyXg3k9wctbyeuNiN3hEY0kRguqe/K5kE4NLpGRNFMGTSLoK41IKpO2+IeSP2k zb0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp13si10637644ejc.210.2021.03.28.04.15.47; Sun, 28 Mar 2021 04:16:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231185AbhC1LMt (ORCPT + 99 others); Sun, 28 Mar 2021 07:12:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:37428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbhC1LMT (ORCPT ); Sun, 28 Mar 2021 07:12:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDE126192F; Sun, 28 Mar 2021 11:12:17 +0000 (UTC) Date: Sun, 28 Mar 2021 12:12:15 +0100 From: Catalin Marinas To: Masahiro Yamada Cc: linux-arm-kernel , Linux Kernel Mailing List , Nathan Chancellor , Will Deacon Subject: Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig Message-ID: <20210328111213.GA17535@arm.com> References: <20210324071128.1723273-1-masahiroy@kernel.org> <20210326143630.GD5126@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 28, 2021 at 03:59:29PM +0900, Masahiro Yamada wrote: > On Fri, Mar 26, 2021 at 11:36 PM Catalin Marinas > wrote: > > On Wed, Mar 24, 2021 at 04:11:28PM +0900, Masahiro Yamada wrote: > > > $(call ld-option, --fix-cortex-a53-843419) in arch/arm64/Makefile is > > > evaluated every time even for Make targets that do not need the linker, > > > such as "make ARCH=arm64 install". > > > > > > Recently, the Kbuild tree queued up a patch to avoid needless > > > compiler/linker flag evaluation. I beleive it is a good improvement > > > itself, but causing a false-positive warning for arm64 installation > > > in linux-next. (Thanks to Nathan for the report) > > > > > > Kconfig can test the linker capability just once, and store it in the > > > .config file. The build and installation steps that follow do not need > > > to test the liniker over again. > > > > > > Reported-by: Nathan Chancellor > > > Signed-off-by: Masahiro Yamada > > > --- > > > > > > I was not sure what the preferred CONFIG option name is. > > > Please suggest a one if you have a better idea. > > > > > > > > > arch/arm64/Kconfig | 3 +++ > > > arch/arm64/Makefile | 2 +- > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > Would you like this patch to go in via the arm64 tree or you will queue > > it via the kbuild tree? > > I applied this to linux-kbuild with Will's Ack. Great, I'll cross it off my list. Thanks. -- Catalin