Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 28 Mar 2021 14:40:02 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Douglas Anderson <dianders@chromium.org>,
        Jason Wessel <jason.wessel@windriver.com>,
        kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kgdbts: Switch to do_sys_openat2() for breakpoint testing
Message-ID: <YGB5IlM7/WqSOdQ2@kroah.com>
References: <20210325094807.3546702-1-daniel.thompson@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210325094807.3546702-1-daniel.thompson@linaro.org>
Precedence: bulk

On Thu, Mar 25, 2021 at 09:48:07AM +0000, Daniel Thompson wrote:
> Currently kgdbts can get stuck waiting for do_sys_open() to be called
> in some of the current tests. This is because C compilers often
> automatically inline this function, which is a very thin wrapper around
> do_sys_openat2(), into some of its callers. gcc-10 does this on (at least)
> both x86 and arm64.
> 
> We can fix the test suite by placing the breakpoints on do_sys_openat2()
> instead since that isn't (currently) inlined. However do_sys_openat2() is
> a static function so we cannot simply use an addressof. Since we are
> testing debug machinery it is acceptable to use kallsyms to lookup a
> suitable address because this is more or less what kdb does in the same
> circumstances. Re-implement lookup_addr() to be based on kallsyms rather
> than function pointers.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> 
> Notes:
>     So less than a week ago I said I had nothing pending for kgdbts.
>     That was entirely true when I said it... but then this came up.

No worries, I'll take this too :)

thanks,

greg k-h