Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2913201pxf; Sun, 28 Mar 2021 06:02:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiyrVzgmyji7nN6sHy3zsvOU8NkMk2eyXZnI0f0NGs3TZQ2FotTeseQ36itHydHB9Lbj6n X-Received: by 2002:a17:906:3750:: with SMTP id e16mr24130987ejc.75.1616936526913; Sun, 28 Mar 2021 06:02:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616936526; cv=none; d=google.com; s=arc-20160816; b=dcxP2URBxHi4zP/VjHSkLLI6L517YXngs83y5fx+nertpgtZ/navZ/qee0gD1Fpvix I/ot4TTPblJGY+jSer8VmQBLvCoV4YM5h50rQmQCsnMwb98CIHhPIKgYGbliaFql0yh4 4dWX2t4qfv57OVnbl+QYcSVm2ct+iRc4B475nL+wiBFkbZQpIQz3qyezVlVGj0UZs7XI 1ipaZBeBd0ceX3/KNonMEjWqLtU5PzYiRk/qCSM6n8OG5uZlfLRHG31Ro5GRz3YH5oq6 7eVAb4NhvbSQ3sqjVB3wH7JLiKJ/LS06kf5dv6t2UdC0LJAphdryadU9QDJXmsmBuket pExA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1k4BSAgCgy7i4IO2T1sXAPrwM/bnZxbx91bJvLp0gsc=; b=a8NLJ7wdnQlsTenSQykmkB8abBKjfNLktQgS2VCvYIOvqBnxU8MNbSS7IU4iaHKzh3 JKkOLT6t5VBn6c6xDgcmEYrfiWba00WxQISKoVxrkvlDuQReu906wt0V1dobvPH3xyvm pAZE1Xayy2ldN1EAinwe5ImGmVfgDvKX+pTuBi6UPr1bWWWySbPrb3t7MG8FgfTjq4FK K5b500ABX/Yuycxx3hppNsNfkCeEKrYSv0TLmNiS8ERYz5IhNfrD5+vUyygcC6B19jcD RaWqva6cW756RuqIQjSKqn1KVpsIp/NotJKfInVgS672ZFESGEQiD/9OhBvqj1PM09Ia B9TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zCIvCtYW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si10789423ejx.75.2021.03.28.06.01.44; Sun, 28 Mar 2021 06:02:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zCIvCtYW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbhC1M6N (ORCPT + 99 others); Sun, 28 Mar 2021 08:58:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:52706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbhC1M5m (ORCPT ); Sun, 28 Mar 2021 08:57:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B18DC6196D; Sun, 28 Mar 2021 12:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616936262; bh=pOX4+0NYh2O97DU5Xq26+Hfg1PTnO3nPtyGDd7KAqB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zCIvCtYWJAgYrjqHB/5AwPVZFSGb94Zc1+d1dmbyBmIZcX6QCLpWlth944DRlBDqL 6EHJk7/wUWsEvI6+nMeyGep2UYyFuZdF1OpQIcK2YnB7WTE4OnkfI0f3wIPgw+M1Ph I1Kezx0bDsWCZVXucupccSwz7fQ0pkwclE5bINrM= Date: Sun, 28 Mar 2021 14:57:39 +0200 From: Greg KH To: Mihai Carabas Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, bobo.shaobowang@huawei.com, rdunlap@infradead.org Subject: Re: [PATCH v8] add support for pci in the pvpanic driver Message-ID: References: <1616597356-20696-1-git-send-email-mihai.carabas@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1616597356-20696-1-git-send-email-mihai.carabas@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 04:49:13PM +0200, Mihai Carabas wrote: > This patchset adds support for PCI in the pvpanic driver. The device already > got in qemu [1]. > > v2: > - mmio -> MMIO, pci -> PCI suggested by Randy Dunlap. > - group pvpanic-common.c and mmio.c in the same module. The intention was to > have only one module and the common code splitted up to be re-used by the > pvpanic-pci module in the next patch. > - add a new patch where add the licenses for the new files (when I moved the > code to mmio.c I preserved the original licenses there) > - properly clean-up PCI device when driver removed. > > v3: > - drop patch 3 with licenses and add them when creating files > - create a new patch (2/3) which allowes multiple pvpanic instances > > v4: > - fix Makefile in patch 1/3 and 3/3 for pvpanic.o as suggested by Arnd > > v5: > - rebase on 5.12 > - fix a warning caused by one of the patches > > v6: > - remove pr_fmt as were not used > - "remove" functions of type void > - moved events/capability per-device structure > > v7: > - rebased on char-misc-next > > v8: > - fixed build error while compiling only the first patch (accept > my apologizes Greg) > - build and tested pvpanic functionality after each applied patch Much better, now queued up, thanks for sticking with it. greg k-h