Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1] Input: elants_i2c - fix division by zero if firmware
 reports zero phys size
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Johnny Chuang <johnny.chuang.emc@gmail.com>,
        Jasper Korten <jja2000@gmail.com>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        linux-input@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210302100824.3423-1-digetx@gmail.com>
 <YGAJmGqNitQ9XwVl@google.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <ee24fc68-0e58-df10-8b3f-a1b18f95e4ad@gmail.com>
Date:   Sun, 28 Mar 2021 20:21:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YGAJmGqNitQ9XwVl@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

28.03.2021 07:44, Dmitry Torokhov пишет:
> Hi Dmitry,
> 
> On Tue, Mar 02, 2021 at 01:08:24PM +0300, Dmitry Osipenko wrote:
>> Touchscreen firmware of ASUS Transformer TF700T reports zeros for the phys
>> size. Hence check whether the size is zero and don't set the resolution in
>> this case.
>>
>> Reported-by: Jasper Korten <jja2000@gmail.com>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>
>> Please note that ASUS TF700T isn't yet supported by upstream kernel,
>> hence this is not a critical fix.
>>
>>  drivers/input/touchscreen/elants_i2c.c | 8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
>> index 4c2b579f6c8b..a2e1cc4192b0 100644
>> --- a/drivers/input/touchscreen/elants_i2c.c
>> +++ b/drivers/input/touchscreen/elants_i2c.c
>> @@ -1441,14 +1441,16 @@ static int elants_i2c_probe(struct i2c_client *client,
>>  
>>  	touchscreen_parse_properties(ts->input, true, &ts->prop);
>>  
>> -	if (ts->chip_id == EKTF3624) {
>> +	if (ts->chip_id == EKTF3624 && ts->phy_x && ts->phy_y) {
>>  		/* calculate resolution from size */
>>  		ts->x_res = DIV_ROUND_CLOSEST(ts->prop.max_x, ts->phy_x);
>>  		ts->y_res = DIV_ROUND_CLOSEST(ts->prop.max_y, ts->phy_y);
>>  	}
>>  
>> -	input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res);
>> -	input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res);
>> +	if (ts->x_res > 0)
>> +		input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res);
> 
> There is absolutely no difference between setting respluton to 0 vs not
> setting it at all, so I dropped the conditionals and applied.
> 
>> +	if (ts->y_res > 0)
>> +		input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res);
>>  	if (ts->major_res > 0)
> 
> We could drop this condition as well.
> 
>>  		input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, ts->major_res);

I'll make a follow up patch to clean up this condition, if you haven't
done it yet. Thanks!