Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3087062pxf; Sun, 28 Mar 2021 11:13:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJya+PN5nm82Hhxq2RLx1+hRMOxODdFCIZ8XcNAS+1IVHPEaNFysTRvTuklb2RTcArK02ssT X-Received: by 2002:a17:906:bcfc:: with SMTP id op28mr24966779ejb.238.1616955186917; Sun, 28 Mar 2021 11:13:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616955186; cv=none; d=google.com; s=arc-20160816; b=d24lxXBGpMWwBy3IHFKbnBfQCGTYzuR4IWjMa+ra9/bg04PRn7qNGEYENiFOEM01uZ dz+1J1zIDo7RaFJXzWLq/+qxwwljjresWUtX927zQ+mFqk+dYosZ09hkVIjf6S4MrAfa tvdiZcUiIdG4PFnSHp3itX4jg9t730mKr2HxCB9Ij+P6J+yTeP2QS3upZynV95Ye+AIv cT/qsIqotlsXuxLr+zXaOk1ZyYAZ5Ye5eJVq29H5wtMn3j10Kxn55Hpb/zDVE2ZCmorG hvieSRxCRmZrk7s03bbwtd1dlktGD+2D0r6cJGAO4QuvYxvYOQGFywQgGEd2mbhlChPW QTkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=tJFqkp3W4qtbjuAfJY/hxKAjSN0tZuQ5pYbgGK8/sSc=; b=HHckBGIseosmaM4i0UKc02PH59xH7Smo1WeTw/ym6dMFaDM6NPG0WVWo0PZjh0veQ2 tlv+tizLjXfQmX3Reedl/BBBH1dnNItItTsjMzc73xwTt1IC6MTBG0hw/Ct6U6wTQKe9 Y3oB2PMSM6OLTSR1YvqDU6ZsgKkl7dz9kZ8VqE5dsTwb8R8g3SG2s8SVzmUq7F5WMyGM vtwuDViIf0bjPYfXw5kvFBgero0WVTMUlVp8UPOHXqHfx/dTxEHmiX/pZyjSc3fs2kdC fG/X5vPBy7N2x4kQDymuXswYjAiQGSn8vlyA6E/FeC6Ij3Zpcp0XxwGCo1S1KxQwUtUj rrHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w22si11078395edd.295.2021.03.28.11.12.44; Sun, 28 Mar 2021 11:13:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbhC1SJE (ORCPT + 99 others); Sun, 28 Mar 2021 14:09:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231580AbhC1SId (ORCPT ); Sun, 28 Mar 2021 14:08:33 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58095C061756; Sun, 28 Mar 2021 11:08:33 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lQZpw-000UWX-Bl; Sun, 28 Mar 2021 18:08:32 +0000 Date: Sun, 28 Mar 2021 18:08:32 +0000 From: Al Viro To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/18] ovl: stack fileattr ops Message-ID: References: <20210325193755.294925-1-mszeredi@redhat.com> <20210325193755.294925-4-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325193755.294925-4-mszeredi@redhat.com> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 08:37:40PM +0100, Miklos Szeredi wrote: > Add stacking for the fileattr operations. > > Add hack for calling security_file_ioctl() for now. Probably better to > have a pair of specific hooks for these operations. Umm... Shouldn't you remove the old code from their ->ioctl() instance?