Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 28 Mar 2021 21:30:49 +0200 (CEST)
From:   Jozsef Kadlecsik <kadlec@netfilter.org>
To:     Wan Jiabing <wanjiabing@vivo.com>
cc:     Pablo Neira Ayuso <pablo@netfilter.org>,
        Florian Westphal <fw@strlen.de>,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] netfilter: ipset: Remove duplicate declaration
In-Reply-To: <20210327025454.917202-1-wanjiabing@vivo.com>
Message-ID: <508fa09b-b2a2-b88f-35b1-d6d3d2a24254@netfilter.org>
References: <20210327025454.917202-1-wanjiabing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 27 Mar 2021, Wan Jiabing wrote:

> struct ip_set is declared twice. One is declared at 79th line,
> so remove the duplicate.

Yes, it's a duplicate. Pablo, could you apply it?

> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Acked-by: Jozsef Kadlecsik <kadlec@netfilter.org>

Best regards,
Jozsef
> ---
>  include/linux/netfilter/ipset/ip_set.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/netfilter/ipset/ip_set.h b/include/linux/netfilter/ipset/ip_set.h
> index 46d9a0c26c67..10279c4830ac 100644
> --- a/include/linux/netfilter/ipset/ip_set.h
> +++ b/include/linux/netfilter/ipset/ip_set.h
> @@ -124,8 +124,6 @@ struct ip_set_ext {
>  	bool target;
>  };
>  
> -struct ip_set;
> -
>  #define ext_timeout(e, s)	\
>  ((unsigned long *)(((void *)(e)) + (s)->offset[IPSET_EXT_ID_TIMEOUT]))
>  #define ext_counter(e, s)	\
> -- 
> 2.25.1
> 
> 

-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
          H-1525 Budapest 114, POB. 49, Hungary