Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] dt-binding: leds: Document leds-multi-gpio bindings
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Hermes Zhang <chenhui.zhang@axis.com>, dmurphy@ti.com,
        robh+dt@kernel.org, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        chenhuiz@axis.com, lkml@axis.com, kernel@axis.com
References: <20210324075631.5004-1-chenhui.zhang@axis.com>
 <20210324075631.5004-3-chenhui.zhang@axis.com>
 <0648fff2-5b38-66da-7eb0-9969e517421f@gmail.com>
 <20210325184140.GA16039@duo.ucw.cz>
From:   =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= <dachaac@gmail.com>
Message-ID: <6313e117-e0f8-ef7c-9165-96c5d2b9d318@gmail.com>
Date:   Sun, 28 Mar 2021 23:46:16 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210325184140.GA16039@duo.ucw.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 25.3.2021 20.41, Pavel Machek wrote:
>>> +  led-gpios:
>>> +    description: Array of one or more GPIOs pins used to control the LED.
>>> +    minItems: 1
>>> +    maxItems: 8  # Should be enough
>>
>> We also have a case with multi color LEDs (which is probably a more common
>> than multi intensity LED. So I am wondering how these both could co-exist.
>>
>> From: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-gpio.yaml?h=v5.12-rc4#n58
>>
>>          led-0 {
>>              gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>;
>>              linux,default-trigger = "disk-activity";
>>              function = LED_FUNCTION_DISK;
>>          };
>>
>> Now 'gpios' (and in LED context) and 'led-gpios' is very close to each other
>> and could easily be confused.
>>
>> Perhaps this could be something like:
>>
>> intensity-gpios = ...
>>
>> or even simplified then just to gpios = <...>
> 
> ...
>> How would this sound?
> 
> Well, not too bad on a quick look.
> 
> Are you willing to implement such multi-color-multi-bit-multi-gpio
> driver?

We have a need for multi color GPIO LED support so I can work on that if 
no one else gets there before me -- I do not have hardware with multiple 
GPIO lines controlling the brightness so that needs a bit more effort in 
order to test that out.

At some point of time I could also revive the PWM stuff if no one else 
beats me to it -- but probably the GPIO variant is easier to get done as 
binary states are easier.

Thanks,
Vesa Jääskeläinen