Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3168781pxf; Sun, 28 Mar 2021 14:48:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzmNKqOWKtZ6OhWFQ6NibaNkS5fVuEDkEFuA8bifxQyKEjx84h2VsjmyUUNLXrpQFoxUF2 X-Received: by 2002:a17:906:86c6:: with SMTP id j6mr24800294ejy.197.1616968104824; Sun, 28 Mar 2021 14:48:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616968104; cv=none; d=google.com; s=arc-20160816; b=IYMkT0Ri5T4sfT0XDPk6OK69H/pPZZ4u7f+DKk1wTO2ux96kZqGuMPBim2fHvyu6eQ 20v+mYWVzupsVMDVRa5xRWK+QONYfxtq2H8RSDv4+uffTw9YrvlcaBbb5j+Ucoug1Q5H RqCsttRUQwsxXO8CdgY0ysSIcweYG2lEP+XmCrAfhhNiRjxoL4a84ByAWur202ixD0iG +dkVD/cmU0Fa5NjNmjSGyCakz92dbXfUZb74ZusncT8pujURbK3nojfrOgogdJ6RL86A fB4ZkTzKdUVH347rc36wUr4ky6ILVvF7AQnkaF8GJUtBcSZvcCTqwyW4uVBbBrtH6sJV OYqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rzFuE51HjLtetaV2oxoek+FpFdBLQabZgkx6sZySstg=; b=duJG9bUI0zzTB9rJgI50rKzSEhlb4+/lVp66PBaRZBuBe73IPJwVGTSW4/PKCj26bo hbRSGxPB618YbtezMYLf4LftQqSVWVFtL8Br3F0y5Gi7Uu4m0KCZ8n3QKzPBIWIELMGf 69z9pRnrYiwI7L5TpzF/5xTBT9L2iOXK1jNBHkU6lGB0WLrLvXoJFDDayzxanqKSHN38 HvUZpwfiMR6LlwS/LzKdQmiNrCQVFcK5dP5Ri+uiItimHzsWvv+LO00Z43p/3mv2IdQQ g8N6qokhggUzDeFScM2sVkETy05CwD9rnC+XoeaUyFFNn25UzYD3B55yluREeJkIVZ5X bqyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rHYNafv7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si11781955edt.289.2021.03.28.14.48.02; Sun, 28 Mar 2021 14:48:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rHYNafv7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231511AbhC1VrJ (ORCPT + 99 others); Sun, 28 Mar 2021 17:47:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbhC1Vqb (ORCPT ); Sun, 28 Mar 2021 17:46:31 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5E95C061756; Sun, 28 Mar 2021 14:46:30 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id a11so8118680qto.2; Sun, 28 Mar 2021 14:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rzFuE51HjLtetaV2oxoek+FpFdBLQabZgkx6sZySstg=; b=rHYNafv7PqWQQyAIXR4YDq7gsrZBNureSM6KvkN/3mcNIfnZ3v1scNOjB8d/hX/mZ0 LwzMW8FvqnhWXnHs+l8ZLfFoUv6TYYJIO0102otUTOmZeliRPcvE6PzGlfmr1SZCfxXY 2P/VZa2JK1CZt738ATPQjHe3oB3l0bGdHX8ZI2vObPDWe+u1C/XVNh67Su/3AoksXpNS IWkPS2GdqAbFVtiiAXJd2SxOZ1LNQhYi4+YZ4VemQqTmpotK8Vmdpzw5ntLVX5PLTaDO ysB5jpDL6ic8qvOTfSvaUx9PVPZzmPj7PoAmKigW2NwXpq+AUxatkoM79VWnK4offxMV veaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rzFuE51HjLtetaV2oxoek+FpFdBLQabZgkx6sZySstg=; b=JafxkgROlS/A++9B/5dX8tw4eKbShjzfXL9utZZ8sCTkACMzCE9hrUf27fMheo03Eo FLg8JjnbBMNtdUQhxZhBu8y5n9rHmj5E04ryE3ZbHz7Q3uvFIhwV78tpxv+rVZ9v744l GZ4x2NdEeb1YDFP50JxYhzNguyWfOk4VavwPakPlykeep8bsK8o+5he99/dU5/SBag0r HpXFnBttsNubCdVXS2ug0yUEes42pFVgeLUUpgCcyqDxUCMYKjbJZpHpUyN/XtKKG3qF kDuG1Zd05y18hosjBmfaKAxy68+k3o1hKozA/L+ErpcRps1fkwn9s7hvPIfQMru9Xu89 T43Q== X-Gm-Message-State: AOAM530ugcF8jvKmDB+ftm4aJTshjGydIjVHbfuDE36fQKZakflv2JNx 7KXpigs3L0AfT+uV3YVMSvw= X-Received: by 2002:a05:622a:9:: with SMTP id x9mr20506856qtw.189.1616967990210; Sun, 28 Mar 2021 14:46:30 -0700 (PDT) Received: from smtp.gmail.com ([2804:14c:73:9e91::1002]) by smtp.gmail.com with ESMTPSA id q125sm11825224qkf.68.2021.03.28.14.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 14:46:30 -0700 (PDT) Date: Sun, 28 Mar 2021 18:46:26 -0300 From: Lucas Stankus To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] iio: adc: ad7923: use device-managed function for triggered buffer Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Converts the iio_triggered_buffer_setup() call to its device-managed counterpart. With this, the error handling routine in the ad7923_probe() function becomes unnecessary as well as the iio_triggered_buffer_cleanup() call. Signed-off-by: Lucas Stankus --- drivers/iio/adc/ad7923.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index 3418ef6f0857..d07eaf3111ed 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -351,20 +351,12 @@ static int ad7923_probe(struct spi_device *spi) if (ret) return ret; - ret = iio_triggered_buffer_setup(indio_dev, NULL, - &ad7923_trigger_handler, NULL); + ret = devm_iio_triggered_buffer_setup(&spi->dev, indio_dev, NULL, + &ad7923_trigger_handler, NULL); if (ret) return ret; - ret = iio_device_register(indio_dev); - if (ret) - goto error_cleanup_ring; - - return 0; - -error_cleanup_ring: - iio_triggered_buffer_cleanup(indio_dev); - return ret; + return iio_device_register(indio_dev); } static int ad7923_remove(struct spi_device *spi) @@ -372,7 +364,6 @@ static int ad7923_remove(struct spi_device *spi) struct iio_dev *indio_dev = spi_get_drvdata(spi); iio_device_unregister(indio_dev); - iio_triggered_buffer_cleanup(indio_dev); return 0; } -- 2.31.0