Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3354021pxf; Sun, 28 Mar 2021 23:02:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsPnscSXdnTknxFzjZlV6pnSSwspvGGLHhbYJ/UkYHuLwgBJdtYKisMuUWItvMF+abmTif X-Received: by 2002:a17:906:b846:: with SMTP id ga6mr26654199ejb.542.1616997750149; Sun, 28 Mar 2021 23:02:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616997750; cv=none; d=google.com; s=arc-20160816; b=fGaYdvA4dQ8k0fuIm2O3llDG4RWvjjh4y/1wJvw8fcfbsdvxtGFwKgcUycGxxGYxpQ pI6NhZONpxae9dWOF6qnFJqiXLwvRg2uOYTjCEJo11Aj8aq9TiIjLpqC0dPTi+6dDPuY +bBhDzLL6tOSKVt2sROCn48XAd88DbOEtE9nYHRA1qLRc/hp6dneX04F+AdSi8J/NqsL OAi6ez+Top8Z6J7SzTtOZv0qlNECnveOKpBtzJUeTzeWvDIwMyzaAobF7bTOoEeO2Hud Gqmzp6jDqdCKi22HINLpBex48ksBlk7WmAb819b8Ed3yGi+2kh0oLYFQlaJI2Z4JzMH1 2WSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=vi4w4a4WomT2xgpiO19F6LjEaxN0GBysZtobwMDFqS4=; b=OIPqTci7iZitEzbdkxRXxQUbKtXNbejZCJurh2ZURflNKbHptj/onh9s708vc/rzfT xbEmiRDRwuyo9JFQaFkWaFM3l87BT9ZU6wgH5ZR3yHgwqLYMe86gFkcZRQfUjIF6pST6 OgC0WBGFlkZ2P92zv8sDs6jdJlzS6c2Yi7hdy2mgwjeuVQt357uxgU0EjIr19v1+722M RGRA5iSwabPrC0G69yaiaR0pvXZdNcyvVyWalZnoFjTWsj1UQbxKFKRfsbziqe4U9mIZ fxGYzEkMFf8deWUknBCMu8l5LOU2s0yk5oLTuAQ+/cSAGCCHHGuJrMC8rVBi8j+dFK0o mzdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b="KGTy/rt7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si11435118edq.173.2021.03.28.23.02.07; Sun, 28 Mar 2021 23:02:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b="KGTy/rt7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbhC2GAy (ORCPT + 99 others); Mon, 29 Mar 2021 02:00:54 -0400 Received: from smtp1.axis.com ([195.60.68.17]:65008 "EHLO smtp1.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbhC2GAp (ORCPT ); Mon, 29 Mar 2021 02:00:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1616997645; x=1648533645; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=vi4w4a4WomT2xgpiO19F6LjEaxN0GBysZtobwMDFqS4=; b=KGTy/rt7rQn7AG/E+rerZ9mHIo3NmYlTudXQfTZ+IA5jXT0hG6bgIEiK roFt8LUb8P3z384KCiq3Dc/ie6l0warTz17D9klUKLFC8oz+CUoKduuuM 6VE8Kb7PXpczWJRCkb6k5ExD98qq4dbREvP2IhgDd5Kfj/WfUBCaVaZBp XlMszjO0wM4sEC5Rl0aIOHVca54IDHVV31uM1xxQZ84Ku8b8GfEe/1Pt7 uDHlB13JuojrwrhqpOwnx6riTtwXIex0fzS2Ar68olaJ6Pcu2SRdpCKky mGatF5fRvdIZsHQj36DSJhRouOQu3UMCqbnB5Ky3pJGEneUZLnkOV9BrT w==; From: Hermes Zhang To: Pavel Machek CC: "dmurphy@ti.com" , "robh+dt@kernel.org" , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hermes Zhang , "lkml@axis.com" , kernel Subject: Re: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver Thread-Topic: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver Thread-Index: AQHXIgDn9WkVNzIcREGb9FBG0Jikcw== Date: Mon, 29 Mar 2021 06:00:43 +0000 Message-ID: <314085a9074c4c6db48a1460c42fb2cd@XBOX01.axis.com> References: <20210326052801.17666-1-chenhui.zhang@axis.com> <20210326052801.17666-3-chenhui.zhang@axis.com> <20210326134939.GA11578@duo.ucw.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.0.5.60] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/26/21 9:49 PM, Pavel Machek wrote:=0A= >> + of_property_read_string(node, "default-state", &state);=0A= >> + if (!strcmp(state, "on"))=0A= >> + multi_gpio_led_set(&priv->cdev, priv->cdev.max_brightness);=0A= >> + else=0A= >> + multi_gpio_led_set(&priv->cdev, 0);=0A= > No need for default-state handling, unless you are using it.=0A= >=0A= We will use it, to make the LED default on or off.=0A= =0A= =0A= Best Regards,=0A= =0A= Hermes=0A= =0A=