Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 29 Mar 2021 09:14:35 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org,
        linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 12/17] ASoC: tegra: tegra20_das: clarify expression
Message-ID: <YGF+W2Uum+pHkH6F@orome.fritz.box>
References: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com>
 <20210326215927.936377-13-pierre-louis.bossart@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="u16SdL02k7B5NOWk"
Content-Disposition: inline
In-Reply-To: <20210326215927.936377-13-pierre-louis.bossart@linux.intel.com>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--u16SdL02k7B5NOWk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 26, 2021 at 04:59:22PM -0500, Pierre-Louis Bossart wrote:
> cppcheck warning:
>=20
> sound/soc/tegra/tegra20_das.c:64:60: style: Boolean result is used in
> bitwise operation. Clarify expression with
> parentheses. [clarifyCondition]
>  reg =3D otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P |
>                                                            ^
> sound/soc/tegra/tegra20_das.c:65:61: style: Boolean result is used in
> bitwise operation. Clarify expression with
> parentheses. [clarifyCondition]
>=20
>   !!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P |
>                                                             ^
> sound/soc/tegra/tegra20_das.c:66:61: style: Boolean result is used in
> bitwise operation. Clarify expression with
> parentheses. [clarifyCondition]
>   !!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P |
>                                                             ^
>=20
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
>  sound/soc/tegra/tegra20_das.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

--u16SdL02k7B5NOWk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmBhflsACgkQ3SOs138+
s6GRWw//bi/X8imkX0asE+iIbIjEB/8g0DDtXmC2e58GwHBjtrzNy5YnJGEvD3MX
KDFYn0bSoGKTy+g4SQe86WyPY4m45WEjWJipDG7Y84HxlQrpZfBfLgTYoT6LxLBc
vFoNwz7POLiegrL7xrPXyd1ut6JIm294V5rAO10lDX5o/nW7xXfI0ocV5FE/rcJh
YUSg1l2ITZ7E9pdV3kpaBvfqPUR6jpmHnGWNG7G47tmp0fyjNMIRi6zplq2OGz0j
rXYVU8w1/BxFM4LtCAmo1Fb0Wv9SwZm6u7t4TH5YWChPrRqe72BsI8JXiBGljCf/
dKWANs50A1tg/V8A+cQUycQ/UfSnH82GR0NjxoMyvNTLzlRklQHrYu37T9Umhy8h
ER7k0MT5833AKFCGFn/WN444JgDkop0jl77WICZITHuDXUDf58VY1vi3lBYWRNcO
XNwx/keXxo9NxR7dogIGSDKXtLhgv0REHKRw0Svfic7aRJGHzETUANbMU3CRfv4y
KsLm8JFQ5lnLkxPNYIrwrR2cfmKcTGXs+7JWAulUaZpasekEdguPwwTy4gKmmcz6
VyMv0w/ZcjV7dlnY5EAR/WqRxNBUUiTQ2vvHAfOXa51DuCkdhCqSwiTdKHBaTXZ+
qo8j1m0qkmaptH2mzNpvSxplcomiqVfVKogkp0d57frRFWsqeFk=
=sfBK
-----END PGP SIGNATURE-----

--u16SdL02k7B5NOWk--