Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932802AbWJINKz (ORCPT ); Mon, 9 Oct 2006 09:10:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932801AbWJINKz (ORCPT ); Mon, 9 Oct 2006 09:10:55 -0400 Received: from witte.sonytel.be ([80.88.33.193]:4069 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S932799AbWJINKy (ORCPT ); Mon, 9 Oct 2006 09:10:54 -0400 Date: Mon, 9 Oct 2006 15:09:34 +0200 (CEST) From: Geert Uytterhoeven To: Jan Engelhardt cc: Kyle Moffett , David Howells , Matthew Wilcox , Linus Torvalds , Andrew Morton , sfr@canb.auug.org.au, Linux Kernel Development , linux-arch@vger.kernel.org Subject: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4] In-Reply-To: Message-ID: References: <20061006133414.9972.79007.stgit@warthog.cambridge.redhat.com> <20061006203919.GS2563@parisc-linux.org> <5267.1160381168@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1581 Lines: 56 On Mon, 9 Oct 2006, Jan Engelhardt wrote: > >> > > > Were you planning on porting Linux to a machine with > >> > > > non-8-bit-bytes any > >> > > > time soon? Because there's a lot more to fix than this. > >> > > > >> > > I am considering the case [assuming 8-bit-byte machines] where > >> > > sizeof(u32) is not 4. Though I suppose GCC will probably make a > >> > > 32-bit > >> > > type up if the hardware does not know one. > >> > > >> > If the machine has 8-bit bytes, how can sizeof(u32) be anything other > >> > than 4? > >> > >> typedef unsigned int u32; > >> > >> Though this should not be seen in the linux kernel. > > > > Well, uhh, actually... > > > > All presently-supported architectures do exactly that. Well, some do: > > > > typedef unsigned int __u32; > > #ifdef __KERNEL__ > > typedef __u32 u32; > > #endif > > Ouch ouch ouch. It should better be > > typedef uint32_t __u32; You mean #ifdef __KERNEL__ typedef __u32 u32; #else // Assumed we did #include before typedef uint32_t __u32; #endif ? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/