Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "tiwai@suse.de" <tiwai@suse.de>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: RE: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes
Thread-Topic: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes
Thread-Index: AQHXIotsEijZJQHh4E+llmTFXyVB9aqanZQA
Date:   Mon, 29 Mar 2021 08:00:31 +0000
Message-ID: <DB9PR10MB4746BFA99998CD92D43521BAF17E9@DB9PR10MB4746.EURPRD10.PROD.OUTLOOK.COM>
References: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com>
 <20210326215927.936377-10-pierre-louis.bossart@linux.intel.com>
In-Reply-To: <20210326215927.936377-10-pierre-louis.bossart@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1de9be7b-c681-41d5-e72f-08d8f288b9a7
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2021 08:00:31.4629
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bEjRkS2mWTw5CK408oi/53kpDUiUP+RLVZqP+jf9pAfhqeRXWKdA57FvqLskbHcdcnh8UeQSg0BYGL657kNSQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR1001MB1429
X-Proofpoint-GUID: JCQx20V0OoNtLXLBD5y0nlS1K_wYNuZo
X-Proofpoint-ORIG-GUID: JCQx20V0OoNtLXLBD5y0nlS1K_wYNuZo
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-29_04:2021-03-26,2021-03-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxscore=0
 lowpriorityscore=0 spamscore=0 malwarescore=0 impostorscore=0 adultscore=0
 phishscore=0 suspectscore=0 mlxlogscore=999 clxscore=1011 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000
 definitions=main-2103290061
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Sent: vendredi 26 mars 2021 22:59
> To: alsa-devel@alsa-project.org
> Cc: tiwai@suse.de; broonie@kernel.org; linux-kernel@vger.kernel.org; Pier=
re-
> Louis Bossart <pierre-louis.bossart@linux.intel.com>; Arnaud POULIQUEN
> <arnaud.pouliquen@st.com>; Liam Girdwood <lgirdwood@gmail.com>;
> Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>
> Subject: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes
>=20
> cppcheck warning:
>=20
> sound/soc/sti/uniperif_player.c:1049:24: style:inconclusive: Function
> 'uni_player_init' argument 2 names different: declaration 'uni_player'
> definition 'player'. [funcArgNamesDifferent]
>       struct uniperif *player)
>                        ^
> sound/soc/sti/uniperif.h:1375:24: note: Function 'uni_player_init'
> argument 2 names different: declaration 'uni_player' definition 'player'.
>       struct uniperif *uni_player);
>                        ^
> sound/soc/sti/uniperif_player.c:1049:24: note: Function 'uni_player_init'
> argument 2 names different: declaration 'uni_player'
> definition 'player'.
>       struct uniperif *player)
>                        ^
> sound/soc/sti/uniperif_reader.c:411:24: style:inconclusive: Function
> 'uni_reader_init' argument 2 names different: declaration 'uni_reader'
> definition 'reader'. [funcArgNamesDifferent]
>       struct uniperif *reader)
>                        ^
> sound/soc/sti/uniperif.h:1380:24: note: Function 'uni_reader_init'
> argument 2 names different: declaration 'uni_reader' definition 'reader'.
>       struct uniperif *uni_reader);
>                        ^
> sound/soc/sti/uniperif_reader.c:411:24: note: Function 'uni_reader_init'
> argument 2 names different: declaration 'uni_reader'
> definition 'reader'.
>       struct uniperif *reader)
>                        ^
>=20
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com=
>

Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

Thanks
Arnaud

> ---
>  sound/soc/sti/uniperif.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index
> a16adeb7c1e9..2a5de328501c 100644
> --- a/sound/soc/sti/uniperif.h
> +++ b/sound/soc/sti/uniperif.h
> @@ -1372,12 +1372,12 @@ static __maybe_unused const struct
> snd_pcm_hardware uni_tdm_hw =3D {
>=20
>  /* uniperiph player*/
>  int uni_player_init(struct platform_device *pdev,
> -		    struct uniperif *uni_player);
> +		    struct uniperif *player);
>  int uni_player_resume(struct uniperif *player);
>=20
>  /* uniperiph reader */
>  int uni_reader_init(struct platform_device *pdev,
> -		    struct uniperif *uni_reader);
> +		    struct uniperif *reader);
>=20
>  /* common */
>  int sti_uniperiph_dai_set_fmt(struct snd_soc_dai *dai,
> --
> 2.25.1