Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "tiwai@suse.de" <tiwai@suse.de>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: RE: [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check
Thread-Topic: [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check
Thread-Index: AQHXIotrJjpsBNRHWEitvVA/o530dqqaniNg
Date:   Mon, 29 Mar 2021 08:01:21 +0000
Message-ID: <DB9PR10MB4746812285B4E6A66546C12FF17E9@DB9PR10MB4746.EURPRD10.PROD.OUTLOOK.COM>
References: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com>
 <20210326215927.936377-9-pierre-louis.bossart@linux.intel.com>
In-Reply-To: <20210326215927.936377-9-pierre-louis.bossart@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d90a89a-135f-4c3c-b6df-08d8f288d737
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2021 08:01:21.2116
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bKrWhl5SLd97yFuUxdjkMq1tsRKPAdgLE+qB10uX1T6rkvGrQImyTm2zrJTD5rrK2oL9KsCl5A6xqv4NcdZHfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR10MB2521
X-Proofpoint-GUID: zA5LLp1bTZm1o5i_0Ql61EaAp74PUCeA
X-Proofpoint-ORIG-GUID: zA5LLp1bTZm1o5i_0Ql61EaAp74PUCeA
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-29_04:2021-03-26,2021-03-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxscore=0
 lowpriorityscore=0 spamscore=0 malwarescore=0 impostorscore=0 adultscore=0
 phishscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000
 definitions=main-2103290061
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Sent: vendredi 26 mars 2021 22:59
> To: alsa-devel@alsa-project.org
> Cc: tiwai@suse.de; broonie@kernel.org; linux-kernel@vger.kernel.org; Pier=
re-
> Louis Bossart <pierre-louis.bossart@linux.intel.com>; Arnaud POULIQUEN
> <arnaud.pouliquen@st.com>; Liam Girdwood <lgirdwood@gmail.com>;
> Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>
> Subject: [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check
>=20
> cppcheck warning:
>=20
> sound/soc/sti/sti_uniperif.c:490:6: style: Variable 'ret' is reassigned a=
 value
> before the old one has been used. [redundantAssignment]  ret =3D
> devm_snd_soc_register_component(&pdev->dev,
>      ^
> sound/soc/sti/sti_uniperif.c:486:6: note: ret is assigned  ret =3D
> sti_uniperiph_cpu_dai_of(node, priv);
>      ^
> sound/soc/sti/sti_uniperif.c:490:6: note: ret is overwritten  ret =3D
> devm_snd_soc_register_component(&pdev->dev,
>      ^
>=20
> sti_uniperiph_cpu_dai_of() can return -EINVAL which seems like a good-eno=
ugh
> reason to bail.
>=20
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com=
>

Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

Thanks
Arnaud

> ---
>  sound/soc/sti/sti_uniperif.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c =
index
> 7b9169f04d6e..67315d9b352d 100644
> --- a/sound/soc/sti/sti_uniperif.c
> +++ b/sound/soc/sti/sti_uniperif.c
> @@ -484,6 +484,8 @@ static int sti_uniperiph_probe(struct platform_device
> *pdev)
>  	priv->pdev =3D pdev;
>=20
>  	ret =3D sti_uniperiph_cpu_dai_of(node, priv);
> +	if (ret < 0)
> +		return ret;
>=20
>  	dev_set_drvdata(&pdev->dev, priv);
>=20
> --
> 2.25.1