Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932715AbWJIOKv (ORCPT ); Mon, 9 Oct 2006 10:10:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932856AbWJIOKv (ORCPT ); Mon, 9 Oct 2006 10:10:51 -0400 Received: from mx2.rowland.org ([192.131.102.7]:38928 "HELO mx2.rowland.org") by vger.kernel.org with SMTP id S932715AbWJIOKu (ORCPT ); Mon, 9 Oct 2006 10:10:50 -0400 Date: Mon, 9 Oct 2006 10:10:48 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Cornelia Huck cc: Jaroslav Kysela , Andrew Morton , ALSA development , Takashi Iwai , Greg KH , LKML , Jiri Kosina , Castet Matthieu , Akinobu Mita Subject: Re: [PATCH] Driver core: Don't ignore bus_attach_device() retval In-Reply-To: <20061009131434.6e3ff0e2@gondolin.boeblingen.de.ibm.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 22 On Mon, 9 Oct 2006, Cornelia Huck wrote: > From: Cornelia Huck > > Check for return value of bus_attach_device() in device_add(). Add a > function bus_delete_device() that undos the effects of bus_add_device(). > bus_remove_device() now undos the effects of bus_attach_device() only. > device_del() now calls bus_remove_device(), kobject_uevent(), > bus_delete_device() which makes it symmetric to the call sequence in > device_add(). > > Signed-off-by: Cornelia Huck This looks good to me. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/