Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3416315pxf; Mon, 29 Mar 2021 01:24:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwC/yip62k/t4KGK436ntzS5CHzMWzzTl0SIafMVZZDj9icT7Gg2AHgAVxcIQRsG1ebFc29 X-Received: by 2002:a17:906:c405:: with SMTP id u5mr27539873ejz.341.1617006241580; Mon, 29 Mar 2021 01:24:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617006241; cv=none; d=google.com; s=arc-20160816; b=YBi6Rn3xzs9LQjnO1f7Dkvyn6r8l54/og4dNtsgF2yrTmfQ5gjm2U8gpxJ7kvbfXi4 BlWoaAPPgXl6mUPnH4TaILyW/E27aDoxn6wAwUCoHGZD6a5YBTZUXewx4f3S9e2JFUq6 ehO/hAnYXLc037bSYDotaHsIwno3tR1ZFm/LDNh25IqwiEC3ZSZHOsm1qfithjTYVZMm RSt4ZbB8PB8qPU1Mxv1/AB09efGyPuHlgtGVmCLCOQuC8s7Gdljskn0IFEU6pzimbQhW XqOFK8kf/t3EMNPlu+dtTKz2taSBCkrXuRhU50KOPsswtBE/aScr40ggVcbcJQhQNHx8 HaEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5NpBqMTJTmNVbDSMpHoFMgbu+rJ2uvP65nw3bJCJVe4=; b=bJS35JPQ6KXH17YGyJO8JMshRUt2RtWZnB+dKwVyXd1+U4JGlUn1zJz0YejsbsqsAN 3PxvnVIb0aH+JDzLBJ9UkRJF6ceGWX71myvJqMHjmLfvTuIEScJ0XfBPfNJJF1AzNRVa lEVHgP8uBk3+k8kwRj62GSFQQl3BkDaQ/XJM/ACQz0ckcyJLkOj8AfokotRshfMQJWNC GNsXhNTn5ELJ/KjkOv15LVpQI97Ib1ZyrsopBPGCOIuqwHf8WmgeuC+XGbyS7KIbtZDv TU3tghYsTsjEe81r6ANT4nIWSdYIunY2zuEvmLP76gWWbqFfIhXdjWmIRsF5IloAT/yR lt4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="e0/ONvMW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cf6si12373921ejb.272.2021.03.29.01.23.39; Mon, 29 Mar 2021 01:24:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="e0/ONvMW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233715AbhC2IWO (ORCPT + 99 others); Mon, 29 Mar 2021 04:22:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:57204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231753AbhC2IOB (ORCPT ); Mon, 29 Mar 2021 04:14:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3BE4261932; Mon, 29 Mar 2021 08:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617005636; bh=OMioe41fwUxPCnI4xgzKAmi2drPv4I2OSCRk0BUk84c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e0/ONvMWxzvCEntD3N1Z1/PBlb9Cbi4Ntp4hzn9T5B6dCi59pGIXdE7PlTWS5KAmY iybQsUcCRlx1+EghEXHNOpxWeuBy6FLlGCOcwQwI6M6IXpitdKv9TGFaXWEik0s43b Ied2aZSiYl+oggzc+/ta2fmqLenmtH3lhL1Ub8Us= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Muhammad Husaini Zulkifli , Malli C , Dvora Fuxbrumer , Sasha Neftin , Tony Nguyen , Sasha Levin Subject: [PATCH 5.4 062/111] igc: Fix Supported Pause Frame Link Setting Date: Mon, 29 Mar 2021 09:58:10 +0200 Message-Id: <20210329075617.275738958@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210329075615.186199980@linuxfoundation.org> References: <20210329075615.186199980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Muhammad Husaini Zulkifli [ Upstream commit 9a4a1cdc5ab52118c1f2b216f4240830b6528d32 ] The Supported Pause Frame always display "No" even though the Advertised pause frame showing the correct setting based on the pause parameters via ethtool. Set bit in link_ksettings to "Supported" for Pause Frame. Before output: Supported pause frame use: No Expected output: Supported pause frame use: Symmetric Fixes: 8c5ad0dae93c ("igc: Add ethtool support") Signed-off-by: Muhammad Husaini Zulkifli Reviewed-by: Malli C Tested-by: Dvora Fuxbrumer Acked-by: Sasha Neftin Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c index d1a25d679b89..cbcb8611ab50 100644 --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c @@ -1690,6 +1690,9 @@ static int igc_get_link_ksettings(struct net_device *netdev, Autoneg); } + /* Set pause flow control settings */ + ethtool_link_ksettings_add_link_mode(cmd, supported, Pause); + switch (hw->fc.requested_mode) { case igc_fc_full: ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause); -- 2.30.1