Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3416356pxf; Mon, 29 Mar 2021 01:24:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX+49iaTBBcbZhlEW0q+sUbfTST6KGZF5L34tV58thDwj6rugUi59quaTODYOPpjROIy2e X-Received: by 2002:aa7:c6d2:: with SMTP id b18mr27236326eds.183.1617006244102; Mon, 29 Mar 2021 01:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617006244; cv=none; d=google.com; s=arc-20160816; b=KE+JPBdrrv/V1suv0O8oeCuvMAgEHIlojQgV/taH+4sdhGXC5fQ9nBvC/GrUHp9GKF gGPaLEOm4LVkhvRWr+AVfBetL9CXUKP7RfIyVt3eIga9yDpD894m3jDtdogn1v/WJF1/ VAnNXtpTY9UT7mzhnHAmJd3LfwIGjs/66gnG8yUhXHbB/9RD5T7OedXOi+KxyCuGDFcd 743hE5uK4izZVe1gvJ4gy/31MhBa3W6+QxUVFxsHYNV8L0Irfcmuz3W8hMiWFx1mj/Ez 3GmBaz6qqfaElYH5216qQvroaK8mbgCWNjUOBzxhsqbwRJ8XGliSmHqCJCPOYpUmmnnr IQpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EwxoxuA2q/IpkxHc7YGbjVOSqK50rKxBMBhKrs4TENc=; b=AWiBOwG3fy6LCYiWaBFOPC3gALdpH5WPW2J9pHM/D9RcNX2KLcilVcBKXtsrZebh7H WO6TmVNV9J4YfSDeYo+U8RbFf733K7OEo0RF3TvBTZ91djSDVKut0Qa5hmliIedq1Igf 2aB644GPOwZqXZnd5+Pa5ZFNnHf+1j3LeJbwjBusvalV69oco8iCr446ACGwX4IRyt5l 8dma9wA0a9aqE9ijvGcsjKaeO1mYI7AfqlGQCFxefZvAYM+nMF2LnH6TawNiRsMS599k Jb6UCyGk/JeGKbI8dGi3pgORbJb5ayO20LLzQ2gl9kZ4Q+Q4n70mbI0TxVt7fwyp+806 yKvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sIGjhf5r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a6si11898018ejt.551.2021.03.29.01.23.41; Mon, 29 Mar 2021 01:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sIGjhf5r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233951AbhC2IWi (ORCPT + 99 others); Mon, 29 Mar 2021 04:22:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:58912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232101AbhC2IOk (ORCPT ); Mon, 29 Mar 2021 04:14:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 357C4619B6; Mon, 29 Mar 2021 08:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617005673; bh=EOnjA+3pLbDJNxTO1rcFVt5YZFr2aDn0wl7rCd/rzT8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sIGjhf5r2aXERAqhTytZ9PWCgkW6d5GPQU1K/uqK7WisGynlglXTBVaryuvi7ysHt 70xT8H5hXFvqv5y5cy/BlGe38vQ5Bb5kwIfYWrrjO8fnRtd5GiPOD8U3A4zKDDKL/j QoYHRiesx7sXSg5hjB8NkfUzLJH3cTLTYU/8Ctvs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hannes Reinecke , Keith Busch , Sagi Grimberg , Chao Leng , Daniel Wagner , Christoph Hellwig , Sasha Levin Subject: [PATCH 5.4 032/111] nvme: add NVME_REQ_CANCELLED flag in nvme_cancel_request() Date: Mon, 29 Mar 2021 09:57:40 +0200 Message-Id: <20210329075616.247197475@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210329075615.186199980@linuxfoundation.org> References: <20210329075615.186199980@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hannes Reinecke [ Upstream commit d3589381987ec879b03f8ce3039df57e87f05901 ] NVME_REQ_CANCELLED is translated into -EINTR in nvme_submit_sync_cmd(), so we should be setting this flags during nvme_cancel_request() to ensure that the callers to nvme_submit_sync_cmd() will get the correct error code when the controller is reset. Signed-off-by: Hannes Reinecke Reviewed-by: Keith Busch Reviewed-by: Sagi Grimberg Reviewed-by: Chao Leng Reviewed-by: Daniel Wagner Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 308f3a28e12a..67ea531e8b34 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -312,6 +312,7 @@ bool nvme_cancel_request(struct request *req, void *data, bool reserved) return true; nvme_req(req)->status = NVME_SC_HOST_ABORTED_CMD; + nvme_req(req)->flags |= NVME_REQ_CANCELLED; blk_mq_complete_request(req); return true; } -- 2.30.1