Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3422516pxf; Mon, 29 Mar 2021 01:37:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy53WAU3drL20z/t2RpV/rtxqMJwE+XeNMEvgAocRkVBf6O0oiqSaSuGWo+JjKZnxG2zGHi X-Received: by 2002:aa7:c398:: with SMTP id k24mr27358943edq.61.1617007026096; Mon, 29 Mar 2021 01:37:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617007026; cv=none; d=google.com; s=arc-20160816; b=BZxOkxyXBHw7j4SslQrN61FA1NCwfSvRwehvter+TCx4vxCNjAQiC1Vtsiviy38jcH JCoUhHFgKnSAplYD3WjzOtEEYMtbB3ks8X93n/6kea9bhtCqwFwQIZj7BgvL/ChG97Wh 92Yx0bhwByFgssdk/x1aOqmThlMMhw193hbfJ1GbbwoXGtygxbuTxuMaOUgUBwCZLaEp NkmlMcTIVvDBsA4ELVFOknruSyG/QRNluTAKYjPCiTTNSqJMg7j0vaIfLUq5oeY8tv7n 4mCwUmw/THLhfXCAFm73gtWWmHT46VgM1V/wgGmCz9CWNlQKzFM9st5uwFIZcAOIViQO fQiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=c/Fqqz5kB1DzkKcTqkelk/fNyKiyEQJAm/KXVx7v7r4=; b=a1ukAEEmXy0PygrKz5gPHIajkFJht7Qt5H8Ce7NJJjB8f/SOJW4TtWG4n4x0saX04p 6X45sW71KMTM4pOOkJCG3tMlaY0hMKJ4ZWYiJfG1m8NGPFb25dcqatDrf0vEt3rH7gId 1yjPDZ8sxgld6bkXx9P7MaVuu2xsxz8hjtktBmSW/9N1P+KX6belRZqFOBZu0RHGjPCD p7bTR2Z49lVr2VcKucnZY7GswxuQhR2t0rZJgTNzGUY0boohy+4JfY4gNJd58jyNR+gu oEladKVxU85NCtAnva4wymu4T1Kx7evLr1Q37r5swr1tvcbJPaPa1wRjPwlkJTvJpvd1 E+dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o+pbg947; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si12535836ejc.617.2021.03.29.01.36.43; Mon, 29 Mar 2021 01:37:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o+pbg947; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234350AbhC2If1 (ORCPT + 99 others); Mon, 29 Mar 2021 04:35:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:38976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233585AbhC2IVt (ORCPT ); Mon, 29 Mar 2021 04:21:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CE79E61601; Mon, 29 Mar 2021 08:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617006109; bh=b/0ocKoDF281bXAWTvrZcmWZ7NkTfq1eRBYzHXFz/jI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o+pbg947YR18j+Qzb+G2CpA3PRtbtDX1AJJRTAq4zsfRMNstvIHVUFSdvzh45St7R x4vI8fsB1O8PXvM6HeVZdLsy+j3qMKnqTLZfsAwJ8Q8FLIKtIHDKwU1GUPYDxqXZRD yeTmyRbHKNLres8XwoQA/mWGS1KGKY2M/iktCktc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ong Boon Leong , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 121/221] net: phylink: Fix phylink_err() function name error in phylink_major_config Date: Mon, 29 Mar 2021 09:57:32 +0200 Message-Id: <20210329075633.250778580@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210329075629.172032742@linuxfoundation.org> References: <20210329075629.172032742@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ong Boon Leong [ Upstream commit d82c6c1aaccd2877b6082cebcb1746a13648a16d ] if pl->mac_ops->mac_finish() failed, phylink_err should use "mac_finish" instead of "mac_prepare". Fixes: b7ad14c2fe2d4 ("net: phylink: re-implement interface configuration with PCS") Signed-off-by: Ong Boon Leong Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/phylink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index fe2296fdda19..6072e87ed6c3 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -472,7 +472,7 @@ static void phylink_major_config(struct phylink *pl, bool restart, err = pl->mac_ops->mac_finish(pl->config, pl->cur_link_an_mode, state->interface); if (err < 0) - phylink_err(pl, "mac_prepare failed: %pe\n", + phylink_err(pl, "mac_finish failed: %pe\n", ERR_PTR(err)); } } -- 2.30.1