Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932935AbWJIPcK (ORCPT ); Mon, 9 Oct 2006 11:32:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932942AbWJIPcJ (ORCPT ); Mon, 9 Oct 2006 11:32:09 -0400 Received: from witte.sonytel.be ([80.88.33.193]:30633 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S932935AbWJIPcH (ORCPT ); Mon, 9 Oct 2006 11:32:07 -0400 Date: Mon, 9 Oct 2006 17:31:33 +0200 (CEST) From: Geert Uytterhoeven To: Arnd Bergmann cc: Jan Engelhardt , Kyle Moffett , David Howells , Matthew Wilcox , Linus Torvalds , Andrew Morton , sfr@canb.auug.org.au, Linux Kernel Development , linux-arch@vger.kernel.org Subject: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4] In-Reply-To: <200610091727.34780.arnd.bergmann@de.ibm.com> Message-ID: References: <200610091652.26209.arnd.bergmann@de.ibm.com> <200610091727.34780.arnd.bergmann@de.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 51 On Mon, 9 Oct 2006, Arnd Bergmann wrote: > On Monday 09 October 2006 17:05, Geert Uytterhoeven wrote: > > On Mon, 9 Oct 2006, Arnd Bergmann wrote: > > > On Monday 09 October 2006 15:09, Geert Uytterhoeven wrote: > > > > On Mon, 9 Oct 2006, Jan Engelhardt wrote: > > > > > > > > > > Ouch ouch ouch. It should better be > > > > > > > > > > typedef uint32_t __u32; > > > > > > > > You mean > > > > > > > > #ifdef __KERNEL__ > > > > typedef __u32 u32; > > > > #else > > > > // Assumed we did #include before > > > > typedef uint32_t __u32; > > > > #endif > > > > > > Why should that be a valid assumption? Right now, it works > > > if you don't include stdint.h in advance. > > > > According to C99 section 7.18 you need to include first. > > Sorry, I need to rephrase: you can include without > including first, and many people do that. > Relying on uint32_t would mean we break existing source. IC. Well, I meant that of course you have to include at the top of . I just thought inside that particular #ifdef wasn't the right place. Problem solved :-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/