Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3439502pxf; Mon, 29 Mar 2021 02:10:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8RoLp3am7wfcvdlapUkU7qlIEBugHUVRKufOtZrG5MRIVgJQN71N0B4RV1Q+MLmc8Qxjx X-Received: by 2002:aa7:d792:: with SMTP id s18mr27255447edq.176.1617009024460; Mon, 29 Mar 2021 02:10:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617009024; cv=none; d=google.com; s=arc-20160816; b=Bc8GsIm14nocqxyCpKZfGc+D8f5PUU7PTbvMC2C05XUgV7HTBHIdVcsC6JVNhJ75eb w7QDSiR1GsGMgqgKzip46/2PSh9BSuLMkZY6Unj8dSTrTEifwCYbRgqkgNpREE+ZcPAC 33qu34s0hslNdDh8jDZ08L/NsVEb2tFJC/aboe6cC4MGw+QY16ly5fSmMpA0vgF8rPWy F8FhNuuxzDO0S96mO8fFqU0TSJ0v08BkcL/aMoD0fmMASjtM/31/xyuaVX2o9bc6okpD /Bu81zTlSfST3nvnWnpJFqCndE9zVyEYRxEqlH43qzLZLbvmTKqsiDc5Bjxa96HQ/jda 4CLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JpIrGfDs3S8hjWf/y+12BesHBseDP7lVyOhVdoQ0pQM=; b=kfDYPHEcjY5rfKcCxsEzSrRjn8RfRolGOt4xrzuZDK/anIPv2ZEqhXnGq/Q3nhOKF9 racrCtWn7gu5W5M7gnY1hUirGh0baJwWn/CQO3GKd1Gu4W6mlahWRKuoegnIDqyPR3U5 P2JXE5V9L0kmglSijN415+5My5GygbEAVzISakdwdPWpCd72ZyLEC7wpPRlMZ2K1JUhA ZkCmd5Dec3AXhV2xDE2fY4bKuBIpM5WmmrVxbNmVuW0UBhIWrC3fB0Z9H54Sm39bXWQt YxXgmzD6AdLEetE1BNGJtTQiCnp4iz6hwXirygASKxx5mnvCHL97icocimDRB5Ra3F1B NwNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si14151558eda.350.2021.03.29.02.10.00; Mon, 29 Mar 2021 02:10:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236147AbhC2JHC (ORCPT + 99 others); Mon, 29 Mar 2021 05:07:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:55590 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235902AbhC2JAk (ORCPT ); Mon, 29 Mar 2021 05:00:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C6365B3C1; Mon, 29 Mar 2021 09:00:38 +0000 (UTC) Received: from localhost (brahms [local]) by brahms (OpenSMTPD) with ESMTPA id 637eba85; Mon, 29 Mar 2021 09:01:59 +0000 (UTC) Date: Mon, 29 Mar 2021 10:01:58 +0100 From: Luis Henriques To: Matthew Wilcox Cc: "Kirill A. Shutemov" , Miklos Szeredi , Vlastimil Babka , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm Subject: Re: fuse: kernel BUG at mm/truncate.c:763! Message-ID: References: <20210312131123.GZ3479805@casper.infradead.org> <20210315110659.GT2577561@casper.infradead.org> <20210318110302.nxddmrhmgmlw4adq@black.fi.intel.com> <20210318115543.GM3420@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 09:02:33AM +0000, Luis Henriques wrote: > On Thu, Mar 18, 2021 at 11:55:43AM +0000, Matthew Wilcox wrote: > > On Thu, Mar 18, 2021 at 11:29:28AM +0000, Luis Henriques wrote: > > > On Thu, Mar 18, 2021 at 02:03:02PM +0300, Kirill A. Shutemov wrote: > > > > On Thu, Mar 18, 2021 at 11:59:59AM +0100, Miklos Szeredi wrote: > > > > > > [16247.536348] page:00000000dfe36ab1 refcount:673 mapcount:0 mapping:00000000f982a7f8 index:0x1400 pfn:0x4c65e00 > > > > > > [16247.536359] head:00000000dfe36ab1 order:9 compound_mapcount:0 compound_pincount:0 > > > > > > > > > > This is a compound page alright. Have no idea how it got into fuse's > > > > > pagecache. > > > > > > > > > > > > Luis, do you have CONFIG_READ_ONLY_THP_FOR_FS enabled? > > > > > > Yes, it looks like Tumbleweed kernels have that config option enabled by > > > default. And it this feature was introduced in 5.4 (the bug doesn't seem > > > to be reproducible in 5.3). > > > > Can you try adding this patch? > > > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/369a4fcd78369b7a026bdef465af9669bde98ef4 > > Good news, looks like this patch fixes the issue[1]. Thanks a lot > everyone. Is this already queued somewhere for 5.12? Also, it would be > nice to have it Cc'ed for stable kernels >= 5.4. Ping. Are you planning to push this for 5.12, or is that queued for the 5.13 merged window? Or "none of the above"? :) Cheers, -- Lu?s