Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210325193755.294925-1-mszeredi@redhat.com> <20210325193755.294925-4-mszeredi@redhat.com>
 <YGDGICWI6o+1zhPI@zeniv-ca.linux.org.uk>
In-Reply-To: <YGDGICWI6o+1zhPI@zeniv-ca.linux.org.uk>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Mon, 29 Mar 2021 11:24:30 +0200
Message-ID: <CAJfpegun3LHMZ9uVxbf5knZB6w1CnUHHXeYpn_ReCTdXKaFX0w@mail.gmail.com>
Subject: Re: [PATCH v3 03/18] ovl: stack fileattr ops
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Miklos Szeredi <mszeredi@redhat.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Mar 28, 2021 at 8:09 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> On Thu, Mar 25, 2021 at 08:37:40PM +0100, Miklos Szeredi wrote:
> > Add stacking for the fileattr operations.
> >
> > Add hack for calling security_file_ioctl() for now.  Probably better to
> > have a pair of specific hooks for these operations.
>
> Umm...  Shouldn't you remove the old code from their ->ioctl() instance?

Will do, once fuse gets converted.

And fuse will get converted, when I manage to decide on the best way to do it:

1) keep a list of open files for each inode, pick random one for doing
the ioctl (really shouldn't matter which one)

2) do a sequence of open - [sg]et attr - release for each invocation

Thanks,
Miklos