Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 29 Mar 2021 11:26:12 +0200
From:   Jessica Yu <jeyu@kernel.org>
To:     Sami Tolvanen <samitolvanen@google.com>
Cc:     Kees Cook <keescook@chromium.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Tejun Heo <tj@kernel.org>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        Peter Zijlstra <peterz@infradead.org>, bpf@vger.kernel.org,
        linux-hardening@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/17] module: ensure __cfi_check alignment
Message-ID: <YGGdNAygysK8MfnZ@gunter>
References: <20210323203946.2159693-1-samitolvanen@google.com>
 <20210323203946.2159693-5-samitolvanen@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20210323203946.2159693-5-samitolvanen@google.com>
Precedence: bulk

+++ Sami Tolvanen [23/03/21 13:39 -0700]:
>CONFIG_CFI_CLANG_SHADOW assumes the __cfi_check() function is page
>aligned and at the beginning of the .text section. While Clang would
>normally align the function correctly, it fails to do so for modules
>with no executable code.
>
>This change ensures the correct __cfi_check() location and
>alignment. It also discards the .eh_frame section, which Clang can
>generate with certain sanitizers, such as CFI.
>
>Link: https://bugs.llvm.org/show_bug.cgi?id=46293
>Signed-off-by: Sami Tolvanen <samitolvanen@google.com>

Acked-by: Jessica Yu <jeyu@kernel.org>

Thanks!