Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3452365pxf; Mon, 29 Mar 2021 02:36:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywoOcpj4weziYhSxG1P9bMMmE9QIqMuDzlVs/p+geHqUvTVk97jXbhstHTpL/OTbBTsXoh X-Received: by 2002:a17:906:90c5:: with SMTP id v5mr27551980ejw.466.1617010564553; Mon, 29 Mar 2021 02:36:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617010564; cv=none; d=google.com; s=arc-20160816; b=W6to/O0kaX7DqQZgs9a+TI7xN+PJB7V8t4MpTC0LvbdXH1QA0GqpWUWMteGIPXOlFD vY/yvWlcz26cXGMYhmOi06OfLP+evZQtjtcysx0oLAhss7wd87m1uIQlTlIjRzqUPTMg Qk88Gir8qFx7toi8P4/rb/MSaERd+Ro5W7ZrlhIe5vRLIsPDAyufXcjG0x3U6iXLS9uH bIJrfgqYp8WIKiAks98Zhf8pFLiVRT22WwhYlTiom1WRxmfuq6LQSyRpd2PtMnnPQls3 CyjCLS3HAbn3sJrswrbVrL4CWic20q+HgMOhWffX0uTg296l43IA7lv3IdnIgJxZsLa6 ab0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=HS5P7/DigIgLCokpeaphJQu46sK377Ly2VENw/0FmF4=; b=aI8GIjMxmzFt43xVzNfyHz6Aj7FmuNKAJErbQYhbR0nkjhQH0pFs6N96JeQLHS739v o4CIZgfVzmFbFlerppZc5rTtBeWWIzQB59XDjXPV4/1aZmrDZm/1VReTaj56+fy7ZW/N 2DLnL9RzsQZnyZcf4J87LXtjAPPX2JFnUWKhorDel9knksZK+4EZ2ZLrfdjKTSh+K3Hy clxXdAwq89XodCLXklTZMicNnyxUnGzK0Kw5Qd0p+j7aykEL8duqafrjleqcABQLKpUS T74KyeBcC8swA6DeTyn0DmTmNq/aLv2a9nMyR72gbIRoXntYZrSakDpjMCvc47bNbmV9 Qatw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t18si12908678edr.399.2021.03.29.02.35.40; Mon, 29 Mar 2021 02:36:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbhC2Jcw (ORCPT + 99 others); Mon, 29 Mar 2021 05:32:52 -0400 Received: from foss.arm.com ([217.140.110.172]:45292 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231654AbhC2Jcn (ORCPT ); Mon, 29 Mar 2021 05:32:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDF80142F; Mon, 29 Mar 2021 02:32:42 -0700 (PDT) Received: from e123427-lin.arm.com (unknown [10.57.51.224]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 65DE83F7D7; Mon, 29 Mar 2021 02:32:41 -0700 (PDT) From: Lorenzo Pieralisi To: gustavo.pimentel@synopsys.com, bhelgaas@google.com, Dejin Zheng , toan@os.amperecomputing.com, linux-pci@vger.kernel.org, robh@kernel.org Cc: Lorenzo Pieralisi , linux-kernel@vger.kernel.org, dann.frazier@canonical.com Subject: Re: [PATCH] PCI: xgene: fix a mistake about cfg address Date: Mon, 29 Mar 2021 10:32:35 +0100 Message-Id: <161701033575.5341.4105470875260495956.b4-ty@arm.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20210328144118.305074-1-zhengdejin5@gmail.com> References: <20210328144118.305074-1-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 28 Mar 2021 22:41:18 +0800, Dejin Zheng wrote: > It has a wrong modification to the xgene driver by the commit > e2dcd20b1645a. it use devm_platform_ioremap_resource_byname() to > simplify codes and remove the res variable, But the following code > needs to use this res variable, So after this commit, the port->cfg_addr > will get a wrong address. Now, revert it. Applied to pci/xgene, thanks! [1/1] PCI: xgene: Fix cfg resource mapping https://git.kernel.org/lpieralisi/pci/c/f243b619b4 Thanks, Lorenzo