Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Bjorn Helgaas <bhelgaas@google.com>,
        =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>
Subject: RE: [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of
 dw-xdata-pcie driver
Thread-Topic: [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of
 dw-xdata-pcie driver
Thread-Index: AQHXJIJG60dvF/r8ckWOtxY3dz7xnKqavdSAgAAAuiA=
Date:   Mon, 29 Mar 2021 10:25:25 +0000
Message-ID: <DM5PR12MB18353C0E6935F94C457F9595DA7E9@DM5PR12MB1835.namprd12.prod.outlook.com>
References: <cover.1617011831.git.gustavo.pimentel@synopsys.com>
 <5840637a206dd1287caf142a0dbedf0dac9ccd48.1617011831.git.gustavo.pimentel@synopsys.com>
 <YGGnC8LouF+paZ6G@kroah.com>
In-Reply-To: <YGGnC8LouF+paZ6G@kroah.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b3fb758d-06f8-4fba-0f49-08d8f29cf7aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2021 10:25:25.4943
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YaGeUKMsg8UvRXQ9U1+SH7+bwebApqxFWBZNvmgUItVIYTiSbXwymWkpsJUzp2HuSIDlz2KDAN5HPQxJDTzU/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2988
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 29, 2021 at 11:8:11, Greg Kroah-Hartman=20
<gregkh@linuxfoundation.org> wrote:

> On Mon, Mar 29, 2021 at 11:59:40AM +0200, Gustavo Pimentel wrote:
> > This patch describes the sysfs interface implemented on the dw-xdata-pc=
ie
> > driver.
> >=20
> > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> > ---
> >  Documentation/ABI/testing/sysfs-driver-xdata | 46 ++++++++++++++++++++=
++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata
> >=20
> > diff --git a/Documentation/ABI/testing/sysfs-driver-xdata b/Documentati=
on/ABI/testing/sysfs-driver-xdata
> > new file mode 100644
> > index 00000000..66af19a
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-driver-xdata
> > @@ -0,0 +1,46 @@
> > +What:		/sys/class/misc/drivers/dw-xdata-pcie.<device>/write
> > +Date:		April 2021
> > +KernelVersion:	5.13
> > +Contact:	Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> > +Description:	Allows the user to enable the PCIe traffic generator whic=
h
> > +		will create write TLPs frames - from the Root Complex to the
> > +		Endpoint direction.
> > +		Usage e.g.
> > +		 echo 1 > /sys/class/misc/dw-xdata-pcie.<device>/write
>=20
> Again, this does not match the code.  Either fix the code (which I
> recommend), or change this and the other sysfs descriptions of writing
> values here.

I've commented about this previously, but I didn't get feedback on it,=20
therefore I assumed that justification was okay.
I will change the code to accept only the "1" input on the *_store()

-Gustavo

>=20
> thanks,
>=20
> greg k-h