Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3488655pxf; Mon, 29 Mar 2021 03:46:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywj/dRWb9vulre5+hCyjBzQ1mcMgg75AuLbpnO3RsrhvC0v4yhEwb/Y2XtxSOPg/3A8Wyi X-Received: by 2002:a17:906:5ad2:: with SMTP id x18mr27797986ejs.117.1617014782287; Mon, 29 Mar 2021 03:46:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617014782; cv=none; d=google.com; s=arc-20160816; b=F2EofAWqNU+1gICcYKKrZcSgdqd/t5hJn/P0cABs7YjYCxjW/KBT0fqSqxDcynQeym v1Iuz7Frj0IgzMdvMzvE6sKOcyItk01abcJa9EQG72ejolZFn5ER1DoLfpiANuNcTIxN bN1THHEKcePTF9q9fXUbC+TA3xTspwNjLinHsd1uGMQvzcxTG/nqk17jAKZFwaJsd0vE XJP91Ijxv9F8XJid8Jg9sTM9V3JowdZc6ZVIdpUmZRrwNTQj43S2nMgWEIjCHljuH++O m9iVd7vSMgDILfvFfC/g/acxMs0cCg9HAYPC6CrDvp0WfesV1mx5n0jB4Si3iKbTPHwC 6M+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9LiMDUw9PSb1omaKNQwVGCZSMLqprNfj0avbMi0zQrs=; b=DB4poVIcpnnZ7VYZNz3I3zvNYM9869X9CwyftSP9bAaEVyLPKZJmQG5s1QALgIs5Og iFJ/q7oY1Z74mRw7P+ek0OZgEdRwy5s/zNjFKHWNLr4gD+/LmcraepKt8mTr/vfDB6hS vHOU5dtDl1Y9GZ0BVC3BVjnIQ7GGxEitmbyQhts/aDNG/hbX8/y4A0OY1u63GTwAkpTm kh/uIiWezWZOck3qnKr26843vXk8WW1HKI3ufoA6UDeNqMwE+lmBBU77jUi+mKUKsYFT RUJ/Ciki9p6+C1qoiFl926JNQRdn6I3VZlUjd6L0Zk04UaCr04rJIx9TT5EIlsCvf1Gx sKSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l46am3Rk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r16si12771632edw.458.2021.03.29.03.46.00; Mon, 29 Mar 2021 03:46:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l46am3Rk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234131AbhC2Iei (ORCPT + 99 others); Mon, 29 Mar 2021 04:34:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:38380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233538AbhC2IVW (ORCPT ); Mon, 29 Mar 2021 04:21:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7814761932; Mon, 29 Mar 2021 08:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617006082; bh=Itvmwy1S2qgFEM+tQdjJCEoVy+P7Q+pNMr39gdJ9+AI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l46am3RkwEzreLKr15kvUGIbE2AOhQaiKPA4uFjLrLt+hm1HTmNECB22c7WsnSa5+ nCOcuVKlJ4PeqxvzxU+EGfZAlKVUBpkaNIbyT3LLpRPoBBjfoNm2XqDtPBOZmnrah8 H0rEVdJnQ+V4qJZQR1Bj949509JTO7fFhWK2j6Ug= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 112/221] net: phy: broadcom: Add power down exit reset state delay Date: Mon, 29 Mar 2021 09:57:23 +0200 Message-Id: <20210329075632.954177697@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210329075629.172032742@linuxfoundation.org> References: <20210329075629.172032742@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli [ Upstream commit 7a1468ba0e02eee24ae1353e8933793a27198e20 ] Per the datasheet, when we clear the power down bit, the PHY remains in an internal reset state for 40us and then resume normal operation. Account for that delay to avoid any issues in the future if genphy_resume() changes. Fixes: fe26821fa614 ("net: phy: broadcom: Wire suspend/resume for BCM54810") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/broadcom.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index cd271de9609b..69713ea36d4e 100644 --- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c @@ -332,6 +332,11 @@ static int bcm54xx_resume(struct phy_device *phydev) if (ret < 0) return ret; + /* Upon exiting power down, the PHY remains in an internal reset state + * for 40us + */ + fsleep(40); + return bcm54xx_config_init(phydev); } -- 2.30.1